-
-
Notifications
You must be signed in to change notification settings - Fork 166
Add an "accommodation time factor" to provide for extra time on timed tests. #2846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
699d9cd to
99fbfab
Compare
3fcbe93 to
dcff89b
Compare
dcff89b to
ea42e2c
Compare
|
I haven't reviewed this, but I am wondering if "accessibility" is the right word for this. Extended time is an accommodation, and I don't really think of it as having to do with accessibility. |
ea42e2c to
7ff9a62
Compare
|
I just think of it as an accessibility thing, because the requests for students to have extended time always are made by our accessibility resource center. But accommodation is probably a better work. I will make the wording change. |
da6cf43 to
d791b1c
Compare
|
When entering an accommodation time factor, is there any way to protect against invalid input? For example if I enter "1.5a", I get a a perl error. |
… tests. This accesibility time factor is a user property and is set when editing a student on the "Accounts Manager" page. The time that a student will have to complete any timed test is the product of the "Test Time Limit" set for the test on the "Set Detail" page, and this accesibility time factor for the student taking the test. By default the accesibility time factor for each student is 1, but can be set to something like 1.5 to determine that a student is allowed time and a half to complete timed tests. The point of this is that it is a bit tedious to need to go through all timed tests and change the test time limit for all of the students that need to be given extra time for accesibility accomodations. With this you only need to set one number, and it is rather convenient to do so for all of the students in the class that need it from one page. Since this is a per user setting, this requires the addition of a new column to the user table in the database.
|
I will see what can be done. It looks like that is going to take quite a bit of restructuring of the user list code to do anything about it though. There isn't currently a mechanism for data validation there. |
|
A funny thing is that you can use a negative number as well, which is valid from the perspective of the database column type. So no error. But then the test version's close date ends up being earlier than its open date. |
d791b1c to
bbd0cf9
Compare
|
I added validation of the "Accomodation Time Factor". |
bbd0cf9 to
b7e5cfe
Compare
|
Note that I also made it so that the value for the accommodation time factor must be at least 1. There is no valid reason to ever set it to something less than 1. You shouldn't ever insist that a student have less time than the other students in the course, right? |
|
I wonder if there is any standard on to what the factors can be. The only ones I've seen are 1, 1.5, 2. I suspect those are the most common. Though making a drop down menu that only shows the ones we think might arise probably isn't best. Wonder if there is some standard that we could follow for this. |
|
Though making a drop down menu that only shows the ones we think might
arise probably isn't best.
Maybe this would be good, as long as an institution can use a config line
to change the array of options.
Alex Jordan
Mathematics Instructor
Portland Community College
…On Fri, Jan 2, 2026, 10:38 AM Alex Jordan ***@***.***> wrote:
Also unlimited time might be a standard option.
Alex Jordan
Mathematics Instructor
Portland Community College
On Fri, Jan 2, 2026, 10:34 AM Jaimos Skriletz ***@***.***>
wrote:
> *somiaj* left a comment (openwebwork/webwork2#2846)
> <https://urldefense.com/v3/__https://github.com/openwebwork/webwork2/pull/2846*issuecomment-3705996580__;Iw!!Ka_JY85zDv0FFw!mmfEo7j1vQg7W1-lQNJqUGfwJs6WvlZCgWGklhhZRbolBU5C2JV6R4jExPJZe-HL8uwoszp2zmw_zgzjmwFwKnCfL1Q$>
>
> I wonder if there is any standard on to what the factors can be. The only
> ones I've seen are 1, 1.5, 2. I suspect those are the most common. Though
> making a drop down menu that only shows the ones we think might arise
> probably isn't best. Wonder if there is some standard that we could follow
> for this.
>
> —
> Reply to this email directly, view it on GitHub
> <https://urldefense.com/v3/__https://github.com/openwebwork/webwork2/pull/2846*issuecomment-3705996580__;Iw!!Ka_JY85zDv0FFw!mmfEo7j1vQg7W1-lQNJqUGfwJs6WvlZCgWGklhhZRbolBU5C2JV6R4jExPJZe-HL8uwoszp2zmw_zgzjmwFwKnCfL1Q$>,
> or unsubscribe
> <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABEDOAE6CESQYAUNBZOMGZD4E22ZPAVCNFSM6AAAAACLU4UOM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMBVHE4TMNJYGA__;!!Ka_JY85zDv0FFw!mmfEo7j1vQg7W1-lQNJqUGfwJs6WvlZCgWGklhhZRbolBU5C2JV6R4jExPJZe-HL8uwoszp2zmw_zgzjmwFwOGGM9gI$>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
|
|
For now, I am going to leave this as it is. This covers the use cases that should be most common. We never have unlimited time allowed as an accommodation for students. Is that common for you? For now, you can set that for students the old way. That would be more complicated to implement it seems. |
|
I am not sure why we are discussing switching to a drop down. This works well and covers the possibilities (other than the unlimited time which a drop down won't help with the implementation of), so why make that change? |
|
I was just brainstorming mostly, but didn't think a drop down menu was needed. Tested the current setup and all is working as expected. Though I would suggest using a step of 0.5 instead of the default of 1, so the up/down arrows to change the number will be slightly more useful in common cases. I don't know if any places use factors of 1.25 or 1.75, but a step of 0.25 could also be useful. I am okay with how it is, but 1.5 is a very common factor in my use case, so having the arrows able to reach that would be convenient but not needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay with it as is, tested that the setting can be set, won't accept numbers less than 1, or non numbers, so the validation works.
|
Actually, this does not use the default step of 1. It uses a step of "any". That is a special step value that allows any decimal number. Unfortunately the arrows perform an increment or decrement of 1, and there isn't any way to change that while allowing any decimal. Note that setting a step of 0.5 means that numbers like 1.25 are not allowed, and that is not what we want. |
|
I did see the I am okay with it as is, I was just trying to think of various use cases and possible confusion. |
|
This is the design of HTML for floating point numbers. |
This accommodation time factor is a user property and is set when editing a student on the "Accounts Manager" page. The time that a student will have to complete any timed test is the product of the "Test Time Limit" set for the test on the "Set Detail" page, and this accommodation time factor for the student taking the test. By default the accommodation time factor for each student is 1, but can be set to something like 1.5 to determine that a student is allowed time and a half to complete timed tests.
The point of this is that it is a bit tedious to need to go through all timed tests and change the test time limit for all of the students that need to be given extra time for accessibility accommodations. With this you only need to set one number, and it is rather convenient to do so for all of the students in the class that need it from one page.
Since this is a per user setting, this requires the addition of a new column to the user table in the database.