Skip to content

Conversation

@drgrice1
Copy link
Member

@drgrice1 drgrice1 commented Nov 10, 2025

This accommodation time factor is a user property and is set when editing a student on the "Accounts Manager" page. The time that a student will have to complete any timed test is the product of the "Test Time Limit" set for the test on the "Set Detail" page, and this accommodation time factor for the student taking the test. By default the accommodation time factor for each student is 1, but can be set to something like 1.5 to determine that a student is allowed time and a half to complete timed tests.

The point of this is that it is a bit tedious to need to go through all timed tests and change the test time limit for all of the students that need to be given extra time for accessibility accommodations. With this you only need to set one number, and it is rather convenient to do so for all of the students in the class that need it from one page.

Since this is a per user setting, this requires the addition of a new column to the user table in the database.

@drgrice1 drgrice1 force-pushed the accessibility-time-factor branch from 699d9cd to 99fbfab Compare November 10, 2025 12:37
@drgrice1 drgrice1 force-pushed the accessibility-time-factor branch 2 times, most recently from 3fcbe93 to dcff89b Compare December 9, 2025 12:27
@drgrice1 drgrice1 force-pushed the accessibility-time-factor branch from dcff89b to ea42e2c Compare December 10, 2025 13:55
@Alex-Jordan
Copy link
Contributor

I haven't reviewed this, but I am wondering if "accessibility" is the right word for this. Extended time is an accommodation, and I don't really think of it as having to do with accessibility.

@drgrice1 drgrice1 force-pushed the accessibility-time-factor branch from ea42e2c to 7ff9a62 Compare December 19, 2025 11:12
@drgrice1
Copy link
Member Author

I just think of it as an accessibility thing, because the requests for students to have extended time always are made by our accessibility resource center. But accommodation is probably a better work. I will make the wording change.

@somiaj somiaj changed the title Add an "accessibility time factor" to provide for extra time on timed tests. Add an "accommodation time factor" to provide for extra time on timed tests. Dec 19, 2025
@drgrice1 drgrice1 force-pushed the accessibility-time-factor branch 2 times, most recently from da6cf43 to d791b1c Compare January 1, 2026 19:57
@Alex-Jordan
Copy link
Contributor

When entering an accommodation time factor, is there any way to protect against invalid input? For example if I enter "1.5a", I get a a perl error.

… tests.

This accesibility time factor is a user property and is set when editing
a student on the "Accounts Manager" page. The time that a student will
have to complete any timed test is the product of the "Test Time Limit"
set for the test on the "Set Detail" page, and this accesibility time
factor for the student taking the test.  By default the accesibility
time factor for each student is 1, but can be set to something like 1.5
to determine that a student is allowed time and a half to complete timed
tests.

The point of this is that it is a bit tedious to need to go through all
timed tests and change the test time limit for all of the students that
need to be given extra time for accesibility accomodations. With this
you only need to set one number, and it is rather convenient to do so
for all of the students in the class that need it from one page.

Since this is a per user setting, this requires the addition of a new
column to the user table in the database.
@drgrice1
Copy link
Member Author

drgrice1 commented Jan 2, 2026

I will see what can be done. It looks like that is going to take quite a bit of restructuring of the user list code to do anything about it though. There isn't currently a mechanism for data validation there.

@Alex-Jordan
Copy link
Contributor

A funny thing is that you can use a negative number as well, which is valid from the perspective of the database column type. So no error. But then the test version's close date ends up being earlier than its open date.

@drgrice1 drgrice1 force-pushed the accessibility-time-factor branch from d791b1c to bbd0cf9 Compare January 2, 2026 14:02
@drgrice1
Copy link
Member Author

drgrice1 commented Jan 2, 2026

I added validation of the "Accomodation Time Factor".

@drgrice1 drgrice1 force-pushed the accessibility-time-factor branch from bbd0cf9 to b7e5cfe Compare January 2, 2026 14:11
@drgrice1
Copy link
Member Author

drgrice1 commented Jan 2, 2026

Note that I also made it so that the value for the accommodation time factor must be at least 1. There is no valid reason to ever set it to something less than 1. You shouldn't ever insist that a student have less time than the other students in the course, right?

@somiaj
Copy link
Contributor

somiaj commented Jan 2, 2026

I wonder if there is any standard on to what the factors can be. The only ones I've seen are 1, 1.5, 2. I suspect those are the most common. Though making a drop down menu that only shows the ones we think might arise probably isn't best. Wonder if there is some standard that we could follow for this.

@Alex-Jordan
Copy link
Contributor

Alex-Jordan commented Jan 2, 2026 via email

@Alex-Jordan
Copy link
Contributor

Alex-Jordan commented Jan 2, 2026 via email

@drgrice1
Copy link
Member Author

drgrice1 commented Jan 2, 2026

For now, I am going to leave this as it is. This covers the use cases that should be most common. We never have unlimited time allowed as an accommodation for students. Is that common for you? For now, you can set that for students the old way. That would be more complicated to implement it seems.

@drgrice1
Copy link
Member Author

drgrice1 commented Jan 2, 2026

I am not sure why we are discussing switching to a drop down. This works well and covers the possibilities (other than the unlimited time which a drop down won't help with the implementation of), so why make that change?

@Alex-Jordan
Copy link
Contributor

Alex-Jordan commented Jan 2, 2026 via email

@somiaj
Copy link
Contributor

somiaj commented Jan 2, 2026

I was just brainstorming mostly, but didn't think a drop down menu was needed.

Tested the current setup and all is working as expected. Though I would suggest using a step of 0.5 instead of the default of 1, so the up/down arrows to change the number will be slightly more useful in common cases. I don't know if any places use factors of 1.25 or 1.75, but a step of 0.25 could also be useful. I am okay with how it is, but 1.5 is a very common factor in my use case, so having the arrows able to reach that would be convenient but not needed.

Copy link
Contributor

@somiaj somiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with it as is, tested that the setting can be set, won't accept numbers less than 1, or non numbers, so the validation works.

@drgrice1
Copy link
Member Author

drgrice1 commented Jan 2, 2026

Actually, this does not use the default step of 1. It uses a step of "any". That is a special step value that allows any decimal number. Unfortunately the arrows perform an increment or decrement of 1, and there isn't any way to change that while allowing any decimal. Note that setting a step of 0.5 means that numbers like 1.25 are not allowed, and that is not what we want.

@somiaj
Copy link
Contributor

somiaj commented Jan 2, 2026

I did see the any setting, didn't realize that this prevented the arrows from doing steps other than 1 though. Oh well, wonder if the arrows only hitting whole numbers could cause confusing that fractional numbers are also allowed.

I am okay with it as is, I was just trying to think of various use cases and possible confusion.

@drgrice1
Copy link
Member Author

drgrice1 commented Jan 2, 2026

This is the design of HTML for floating point numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants