refactor(oid4vc): convert public_routes.py and routes.py to packages#2934
Closed
burdettadam wants to merge 1 commit intoopenwallet-foundation:mainfrom
Closed
refactor(oid4vc): convert public_routes.py and routes.py to packages#2934burdettadam wants to merge 1 commit intoopenwallet-foundation:mainfrom
burdettadam wants to merge 1 commit intoopenwallet-foundation:mainfrom
Conversation
…ubmodules Split two large monolithic files into organized package directories: public_routes.py (953 lines) -> public_routes/ package: - credential_offer.py: credential offer dereference endpoint - metadata.py: credential issuer metadata endpoint - nonce.py: nonce creation and request - notification.py: notification endpoint - token.py: token endpoint, check_token, proof of possession - credential.py: credential issuance endpoint - verification.py: OID4VP verification (get_request, post_response) - status_list.py: status list endpoint routes.py (1854 lines) -> routes/ package: - exchange.py: exchange record CRUD - credential_offer.py: credential offer helpers and endpoints - supported_credential.py: supported credential CRUD - vp_request.py: VP request creation and listing - vp_dcql.py: DCQL query CRUD - vp_pres_def.py: presentation definition CRUD - vp_presentation.py: VP presentation listing and retrieval - did_jwk.py: DID JWK creation - helpers.py: issuer config endpoints Both __init__.py files re-export all public symbols so existing imports (from oid4vc.routes import X, from oid4vc.public_routes import Y) continue to work without changes. Signed-off-by: Adam Burdett <burdettadam@gmail.com>
burdettadam
force-pushed
the
refactor/oid4vc-route-packages
branch
from
b8aa18c to
ccb749c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert the monolithic
public_routes.pyandroutes.pymodules into Python packages (public_routes/androutes/directories with__init__.pyfiles). This prepares for follow-up PRs that decompose these into focused submodules.Changes
public_routes.py→public_routes/__init__.pyroutes.py→routes/__init__.py.xxx→..xxx) to account for the new nesting depthWhat this does NOT change
from oid4vc.routes import ...,from oid4vc.public_routes import ...) continue to work unchangedVerification
This is the first in a series of PRs decomposing #2871 into smaller, independently reviewable changes.