AutoSlicer: better slicing algorithm#11
Open
Aeterrno-Amora wants to merge 2 commits intoopenvpi:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
取消minLength参数，改为maxLength参数
算法：把所有静音按长度排序，依次看从短到长的静音，如果把静音两侧的片段合并起来长度不超过maxLength就合并。
这样应该会比原来的贪心切得更均匀，且直接指定长度上限更适合炼丹
由于本地环境很难配好build，所以没有测试，麻烦谁帮我测试和build一下，谢谢。
Specify maxLength instead of minLength.
New algorithm: Sort all silence intervals by their length and enumerate them from short to long, and join the two neighboring segments whenever it would result in a segment no longer than maxLength.
So that the resulted segments will be more even in lengths. And specifying maxLength is more consistent with the training setup.