Skip IObservable first init in PreferencesViewModel#2205
Open
atouu wants to merge 4 commits into
Open
Conversation
atouu
changed the title
runit-xze
added a commit
to runit-xze/OpenUtau
that referenced
this pull request
Jul 25, 2026
Merge upstream openutau#2205: Skip IObservable first init in PreferencesViewModel
runit-xze
added a commit
to runit-xze/OpenUtau
that referenced
this pull request
Jul 25, 2026
…wModel Cherry-picked from openutau#2205: openutau#2205
runit-xze
added a commit
to runit-xze/OpenUtau
that referenced
this pull request
Jul 25, 2026
Merge upstream openutau#2205: Skip IObservable first init in PreferencesViewModel
runit-xze
added a commit
to runit-xze/OpenUtau
that referenced
this pull request
Jul 25, 2026
…ton, detach mode UX) Cherry-picked from openutau#2230: openutau#2230 Resolved real conflict in PreferencesViewModel.cs: kept our computed ThemeEditable (from openutau#2205's IObservable fix) and added this PR's DetachPianoRoll property, which is unrelated and used correctly elsewhere in the auto-merged files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When opening PreferencesDialog, preferences get resave 43 times (including writing to prefs.json) causing the preferences window to lag for a bit. We can prevent this by adding .Skip(1) to every IObservable.