Conversation
WalkthroughAdds an Ollama-based model configuration for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@packages/next-wxt/entrypoints/sidepanel/model-config.ts`:
- Line 50: DEFAULT_MODEL_CONFIGS currently contains an entry with baseURL:
'http://localhost:11434/api' which will break for users without Ollama; update
that model config (the entry in DEFAULT_MODEL_CONFIGS that references the
localhost baseURL) to either remove or blank the baseURL and mark it as
local-only by adding a property like localOnly: true or featureFlag:
'ollamaLocal', and update its label (e.g., label: 'deepseek-r1:1.5b (Local)') so
the UI can hide or display it behind a feature flag or show a clear
local/dev-only indicator; ensure any UI code that reads DEFAULT_MODEL_CONFIGS
respects the new localOnly/featureFlag property to avoid presenting the option
to general users.
- Line 53: The icon properties for the Deepseek entries are missing markRaw
wrapping which causes Vue to make the icon components reactive; update the icon
assignments (e.g., the line setting "icon: IconModelDeepseek as unknown as
Component" and the DeepSeek-R1 entry) to wrap the icon with Vue's markRaw (so
use markRaw(IconModelDeepseek) and markRaw for the DeepSeek-R1 icon) to prevent
deep reactivity and avoid dev warnings; locate these in the model-config entries
for the Deepseek models and replace the bare icon references with
markRaw-wrapped references.
🧹 Nitpick comments (1)
packages/next-wxt/package.json (1)
23-23: Inconsistent version management — consider usingcatalog:like other dependencies.All other entries in
dependenciesuse"catalog:"for centralized version management via the pnpm workspace catalog. Hardcoding"~3.3.0"here breaks that convention and may lead to version drift. Addollama-ai-provider-v2to the workspace catalog and reference it as"catalog:"here.- "ollama-ai-provider-v2": "~3.3.0", + "ollama-ai-provider-v2": "catalog:",
Pull Request (OpenTiny NEXT-SDKs)
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit