Fix IP cache purge for IPv4 and IPv6, enhance command parsing - #1075
Open
cvaroqui wants to merge 13 commits into
Open
Fix IP cache purge for IPv4 and IPv6, enhance command parsing#1075cvaroqui wants to merge 13 commits into
cvaroqui wants to merge 13 commits into
Conversation
* a empty buff condition needed to be tested before addressing
the 0 index of a strings.Fields(buff).
* glob patterns to list files named after ip could only match
ipv4. Use {*.*.*.*,*:*} to catch ipv6 too.
Declare a commoncmd function to factorize the arg0 parsing and command options.RID setting. All driver groups commandsets are supported.
To be able to document a "Arguments:" section after "Use:".
The normal template has no provision for args doc, leaving the
developper only with the Long command field to explain args, but
the Long is printed before "Use:". i.e. args details before
summary, confusing.
Example with this patch:
# om svc1 container start -h
Start a container resource. Equivalent to 'instance start --rid container#<ID>'.
Usage:
start [ID] [FLAGS]
Arguments:
ID A container resource index.
Flags:
--color string output colorization yes|no|auto (default "auto")
...
And remove --rid flag from all drvgroup commands to avoid complex merging/override policies and sanity checks to avoid incompatible pos arg and --rid flag (e.f. container ls --rid ip)
Example: $ om system/sec/ceph key ls *ring ceph.opensvc.com.admin.keyring Documented as: $ om system/sec/ceph key ls -h Usage: list [PATTERN] [FLAGS] Arguments: PATTERN A fnmatch key name filter. Flags: --color string output colorization yes|no|auto (default "auto") -h, --help help for list --ignore-not-found allow empty object selections -o, --output string output format json|flat|auto|tab=<header>:<jsonpath>,... (default "auto") -s, --selector string execute on a list of objects This patch hides the --match flag used for that role so far, so backward compat and tests are ok.
Lost by commit c79f275 that added a custom help template not supporting command groups.
* add|change|edit|decode NAME * remove NAME... And add the `rm` alias for `remove`.
Example: om sec/ceph1 key rename keyring keyring.2026
Example:
om sec/ceph1 key install keyring
And tidy key commandset short help messages.
This kw references a datastore key holding a ceph.conf content.
This key is installed as a /run file used to add a -c flag to
rbd commands.
Example:
[disk#2]
type = rados
name = {fqdn}-disk2
size = 100m
keyring = from system/sec/ceph key ceph.opensvc.com.admin.keyring
config = from system/sec/ceph key ceph.conf
In this case the "rbd" default pool must be prepended to the normalized spec before comparing with RBDMap data and when formatting the device path (e.g. /dev/rbd/rbd/myname).
Grouped disks have atomic snapshots. * Do the grouping in provision, ungrouping in unprovision * Create the group if necessary * Drop the group if unused * Make resource status report grouping issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.