Skip to content

Consume common templates via CommonTemplates field#898

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
fmount:templates
May 19, 2026
Merged

Consume common templates via CommonTemplates field#898
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
fmount:templates

Conversation

@fmount
Copy link
Copy Markdown
Contributor

@fmount fmount commented May 18, 2026 •
edited
Loading

The ssl.conf httpd configuration is duplicated across service operators.
This patch removes the local copy and consumes it from lib-common.

Jira: OSPRH-30239

@fmount fmount requested review from abays, jlarriba and stuggi May 18, 2026 15:09
@openshift-ci openshift-ci Bot requested review from dprince and paramite May 18, 2026 15:09
@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented May 18, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/4c1ed359aa464dedab82bdba20d89c38

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 53m 58s
❌ telemetry-operator-multinode-cloudkitty FAILURE in 1h 12m 48s
✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 2h 47m 24s
✔️ telemetry-operator-multinode-default-telemetry SUCCESS in 1h 30m 43s
✔️ telemetry-operator-multinode-audit-logging SUCCESS in 1h 17m 23s
✔️ functional-tests-osp18 SUCCESS in 2h 18m 52s

@fmount
Consume common templates via CommonTemplates field
4226ddc 
Remove duplicated templates from the operator and consume them
from lib-common via the CommonTemplates field. This allows
maintaining common configuration files (e.g. ssl.conf) in a
single location across all operators.

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
stuggi
stuggi approved these changes May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label May 19, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 65fc23d into openstack-k8s-operators:main May 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuggi stuggi stuggi approved these changes

@jlarriba jlarriba Awaiting requested review from jlarriba

@abays abays Awaiting requested review from abays

@dprince dprince Awaiting requested review from dprince

@paramite paramite Awaiting requested review from paramite

Assignees

@stuggi stuggi

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fmount @stuggi