-
Notifications
You must be signed in to change notification settings - Fork 102
Use server-side apply for 'make install' #1775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use server-side apply for 'make install' #1775
Conversation
|
/test openstack-operator-build-deploy-kuttl |
Seems unrelated. /test openstack-operator-build-deploy-kuttl-4-18 |
|
@bshephar: changing LGTM is restricted to collaborators DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
fmount
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, bshephar, dprince The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test openstack-operator-build-deploy-kuttl |
|
/lgtm |
1f9c1ff
into
openstack-k8s-operators:main
If we use the default client-side apply for install the CRDs, this error occurs:
This happens because when using
oc apply, Kubernetes stores the entire manifest in thekubectl.kubernetes.io/last-applied-configuration annotation. For very large CRDs likeOpenStackControlPlane, this exceeds the 262144 byte limit. We don't need to store that annotation information anyhow.