Skip to content

Consume common templates via CommonTemplates field#577

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
fmount:templates
May 19, 2026
Merged

Consume common templates via CommonTemplates field#577
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
fmount:templates

Conversation

@fmount
Copy link
Copy Markdown
Collaborator

@fmount fmount commented May 18, 2026

The ssl.conf httpd configuration is duplicated across service operators.
This patch removes the local copy and consumes it from lib-common.

Jira: OSPRH-30239

Use the new CommonTemplates field in the Template struct to request
ssl.conf from lib-common instead of shipping a local copy.

Co-Authored-By: Claude Opus <noreply@anthropic.com>
Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@fmount fmount requested a review from stuggi May 18, 2026 14:26
@fmount fmount requested a review from gouthampacha May 18, 2026 14:26
@fmount fmount requested a review from abays May 18, 2026 14:26
@fmount fmount changed the title Consume common ssl.conf via CommonTemplates field Consume common templates via CommonTemplates field May 18, 2026
Copy link
Copy Markdown
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 18a3bfb into openstack-k8s-operators:main May 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants