Skip to content

Consume common templates from lib-common#917

Merged
openshift-merge-bot[bot] merged 2 commits into
openstack-k8s-operators:mainfrom
fmount:templates
May 18, 2026
Merged

Consume common templates from lib-common#917
openshift-merge-bot[bot] merged 2 commits into
openstack-k8s-operators:mainfrom
fmount:templates

Conversation

@fmount
Copy link
Copy Markdown
Contributor

@fmount fmount commented May 14, 2026

The ssl.conf httpd configuration is duplicated across service operators.
This patch removes the local copy and consumes it from lib-common.

Jira: OSPRH-30239

@openshift-ci openshift-ci Bot requested review from dprince and konan-abhi May 14, 2026 16:15
@fmount fmount requested review from abays and fultonj May 14, 2026 16:18
@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/236484bce1fa4ce480f2effacfaff113

openstack-k8s-operators-content-provider FAILURE in 6m 43s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/e207ef60f5934529937fb5344e5d0ece

openstack-k8s-operators-content-provider FAILURE in 14m 32s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/90f55bb7105a4574b65741803965dc75

openstack-k8s-operators-content-provider FAILURE in 12m 08s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/8f58c8902d1945b6acb8b1a0a280ab91

openstack-k8s-operators-content-provider FAILURE in 8m 30s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@fmount fmount changed the title Consume common ssl.conf template from lib-common Consume common templates from lib-common May 15, 2026
@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/decd963bc90644e5b9c73ac055cca141

openstack-k8s-operators-content-provider FAILURE in 6m 45s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

Copy link
Copy Markdown
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fmount and others added 2 commits May 18, 2026 16:00
Co-Authored-By: Claude Opus <noreply@anthropic.com>
Signed-off-by: Francesco Pantano <fpantano@redhat.com>
Use the new CommonTemplates field in the Template struct to request
ssl.conf from lib-common instead of calling GetCommonTemplates()
and merging into CustomData manually.

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@openshift-ci openshift-ci Bot removed the lgtm label May 18, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 18, 2026

New changes are detected. LGTM label has been removed.

@abays abays added the lgtm label May 18, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit ee3217c into openstack-k8s-operators:main May 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants