Add view and TSIG key ID fields to pool structs#472
Conversation
Extend pool-related Go structs to support AZ-aware multipool with BIND views and per-pool TSIG keys. Add View field to Options and PoolConfig, TSIGKeyID to Target and Nameserver, and an optional AvailabilityZone pointer to PoolConfig for future AZ routing. Update pools.yaml.tmpl to conditionally render view and tsigkey_id fields only when set, maintaining backward compatibility with existing pool configurations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Abhiram R N <abhiramrn@gmail.com>
|
Hi @abhiramnarayana. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhiramnarayana, omersch381 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit d14ade8
into
openstack-k8s-operators:main
2 participants
Extend pool-related Go structs to support AZ-aware multipool with BIND views and per-pool TSIG keys. Add View field to Options and PoolConfig, TSIGKeyID to Target and Nameserver, and an optional AvailabilityZone pointer to PoolConfig for future AZ routing.
Update pools.yaml.tmpl to conditionally render view and tsigkey_id fields only when set, maintaining backward compatibility with existing pool configurations.