Skip to content

octavia-adoption: perform failover only on amphora LBs#1372

Open
gthiemonge wants to merge 2 commits into
openstack-k8s-operators:mainfrom
gthiemonge:fix_octavia_failover
Open

octavia-adoption: perform failover only on amphora LBs#1372
gthiemonge wants to merge 2 commits into
openstack-k8s-operators:mainfrom
gthiemonge:fix_octavia_failover

Conversation

@gthiemonge
Copy link
Copy Markdown
Contributor

During our tests, tobiko creates an ovn load balancer in the source cloud.
ovn load balancers don't support failovers so they need to be skipped in the "perform failover of existing load balancers" task. Update the docs accordingly.

During our tests, tobiko creates an ovn load balancer in the source
cloud.
ovn load balancers don't support failovers so they need to be skipped in
the "perform failover of existing load balancers" task.
Update the docs accordingly.
Copy link
Copy Markdown
Contributor

@jistr jistr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment thread docs_user/modules/proc_performing-post-adoption-cleanup-of-load-balancers.adoc Outdated
@github-actions
Copy link
Copy Markdown

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this PR will be closed in 7 days.

@github-actions github-actions Bot added the Stale label May 16, 2026
@ciecierski
Copy link
Copy Markdown
Contributor

@gthiemonge Are you planing to land the change? It is marked stale and you have a suggestion from Katie after review to be addressed.

@gthiemonge
Copy link
Copy Markdown
Contributor Author

@gthiemonge Are you planing to land the change? It is marked stale and you have a suggestion from Katie after review to be addressed.

Yeah, I'm still working on it, I'm testing it in the CI

@gthiemonge gthiemonge removed the Stale label May 19, 2026
@ciecierski
Copy link
Copy Markdown
Contributor

@gthiemonge Are you planing to land the change? It is marked stale and you have a suggestion from Katie after review to be addressed.

Yeah, I'm still working on it, I'm testing it in the CI

Ack, thank you for confirming

Co-authored-by: Katie Gilligan <kgilliga@redhat.com>
@openshift-ci openshift-ci Bot removed the lgtm label May 19, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jistr. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Contributor

@jistr jistr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label May 20, 2026
----
+
[NOTE]
OVN load balancers do not support failover because they do not need to be updated during upgrades.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused by this sentence. During an upgrade, is it optional to update OVN load balancers? And what is the distinction between "update" and "upgrade" in this context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants