Retry create_additional_port_for_machines on ConnectionTimeout#1379
Open
dosaboy wants to merge 1 commit into
Open
Retry create_additional_port_for_machines on ConnectionTimeout#1379dosaboy wants to merge 1 commit into
dosaboy wants to merge 1 commit into
Conversation
xtrusia
approved these changes
Jun 12, 2026
xtrusia
left a comment
xtrusia
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Maybe better to add a stop condition though, e.g. stop=tenacity.stop_after_attempt(10)
Contributor
Author
ack ill add that |
If this is called when keystone services are for whatever reason being restarted a timeout occurs and a retry generally works.
dosaboy
force-pushed
the
allow-configure-networks-retry
branch
from
b807068 to
ca72dd4
Compare
Contributor
Author
|
im not sure this is fixing the issue it is intended to so needs a bit more testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this is called when keystone services are for whatever reason being restarted a timeout occurs and a retry generally works.