Add keystone proxy protocol client IP test#1328
Open
xtrusia wants to merge 1 commit into
Open
Conversation
3a6ae89 to
9cf2124
Compare
Enable haproxy-enable-proxy-protocol and check the real client IP is preserved in the keystone apache access log instead of the haproxy backend address. Signed-off-by: Seyeong Kim <seyeong.kim@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add KeystoneProxyProtocolTest for the haproxy-enable-proxy-protocol option from charm-keystone (review 986591, LP#2107999).
The test toggles the option and checks the real client IP is preserved in the apache access log.
Without TLS the keystone WSGI vhost logs it as %h in keystone_access.log; with TLS the https frontend terminates the PROXY connection and proxies over localhost, so the real client IP lands in other_vhosts_access.log instead. Checked on a noble/caracal keystone both with and without TLS.