feat(matrix): MatrixEngine pipeline + system/user prompt split by shlokchorge · Pull Request #36 · openspace-inc/OpenSpace

shlokchorge · 2026-05-08T09:47:34Z

Added MatrixEngine pipeline for milestone generation.
Split the Claude prompt into system and user parts so instructions
go to the system field and goal data goes to the user field.

Also added a new overload in ConvexApiHelper to support this.
Old method is untouched so nothing else breaks.

Copilot

Pull request overview

This PR introduces a new MatrixEngine pipeline for generating milestone timelines via Claude, and splits the prompt into a fixed system prompt (rules/schema) plus a per-request user message (goal parameters). It also adds a new ConvexApiHelper.sendMessageToClaude(systemPrompt, userMessage, ...) overload intended to support the split.

Changes:

Added MatrixEngine to build prompts, call Claude via ConvexApiHelper, parse JSON milestones with fallbacks, and persist results to MatrixStorage.
Added MatrixPrompts to centralize the system/user prompt templates for timeline generation.
Added a ConvexApiHelper overload to send system + user fields separately.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.

File	Description
app/src/main/java/com/example/iaso/matrix/MatrixPrompts.java	Adds system/user prompt constants for Matrix timeline generation.
app/src/main/java/com/example/iaso/matrix/MatrixEngine.java	Implements the milestone generation pipeline, parsing, and persistence into Matrix storage/snapshot.
app/src/main/java/com/example/iaso/ConvexApiHelper.java	Adds an overload intended to send system + user prompts separately to Convex/Claude.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

shlokchorge · 2026-05-08T09:59:26Z

+                    // Validate day sum — soft fix: redistribute remainder into last milestone
+                    int sum = 0;
+                    for (MatrixMilestone m : milestones) sum += m.getAllocatedDays();
+                    if (sum != totalDays) {
+                        Log.w(TAG, "Day sum mismatch: expected " + totalDays + ", got " + sum);
+                        MatrixMilestone last = milestones.get(milestones.size() - 1);
+                        last.setAllocatedDays(Math.max(1, last.getAllocatedDays() + (totalDays - sum)));
+                    }


@copilot apply changes based on this feedback

Implemented in commit e1e5aec: day-sum overflow is now handled explicitly by reducing allocatedDays across milestones from the end (never below 1), recomputing startDay values after normalization, and returning an error if exact normalization to totalDays is impossible.

shlokchorge · 2026-05-08T10:41:59Z

+            JSONObject argsObject = new JSONObject();
+            argsObject.put("systemPrompt", systemPrompt);
+            argsObject.put("userMessage", userMessage);
+
+            JSONObject requestJson = new JSONObject();
+            requestJson.put("path", CONVEX_ACTION_PATH);
+            requestJson.put("args", argsObject);
+


@copilot apply changes based on this feedback

Implemented in commit 45d9eda: the Matrix path now uses an explicit overload sendMessageToClaude(systemPrompt, userMessage, dailyMinutes, totalDays, ...) that sends Convex args as { messages, context } (phase=generating) to match workhorse:getClaudeResponse. The 3-arg overload remains for compatibility and delegates to the new one.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Agent-Logs-Url: https://github.com/openspace-inc/OpenSpace/sessions/5feba14b-fa98-4c8e-a695-06906f047ed3 Co-authored-by: shlokchorge <224512884+shlokchorge@users.noreply.github.com>

Copilot · 2026-05-08T10:05:46Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

dl.google.com
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.7-bin/bhs2wmbdwecv87pi65oeuq5iu/gradle-8.7/lib/gradle-launcher-8.7.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.7-bin/bhs2wmbdwecv87pi65oeuq5iu/gradle-8.7/lib/agents/gradle-instrumentation-agent-8.7.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.7 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Agent-Logs-Url: https://github.com/openspace-inc/OpenSpace/sessions/c366579a-c32c-4480-92c8-f46f945b16f3 Co-authored-by: shlokchorge <224512884+shlokchorge@users.noreply.github.com>

Copilot · 2026-05-08T10:46:16Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

dl.google.com
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.7-bin/bhs2wmbdwecv87pi65oeuq5iu/gradle-8.7/lib/gradle-launcher-8.7.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.7-bin/bhs2wmbdwecv87pi65oeuq5iu/gradle-8.7/lib/agents/gradle-instrumentation-agent-8.7.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.7 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

shlokchorge · 2026-05-08T10:47:20Z

@copilot review is there any error

Agent-Logs-Url: https://github.com/openspace-inc/OpenSpace/sessions/19d0b5fa-446e-4a03-98a3-5cb25c8cc2bf Co-authored-by: shlokchorge <224512884+shlokchorge@users.noreply.github.com>

shlokchorge · 2026-05-08T10:51:18Z

@copilot review

Agent-Logs-Url: https://github.com/openspace-inc/OpenSpace/sessions/19d0b5fa-446e-4a03-98a3-5cb25c8cc2bf Co-authored-by: shlokchorge <224512884+shlokchorge@users.noreply.github.com>

Copilot · 2026-05-08T10:54:12Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

dl.google.com
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.7-bin/bhs2wmbdwecv87pi65oeuq5iu/gradle-8.7/lib/gradle-launcher-8.7.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.7-bin/bhs2wmbdwecv87pi65oeuq5iu/gradle-8.7/lib/agents/gradle-instrumentation-agent-8.7.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.7 (dns block)
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.7-bin/bhs2wmbdwecv87pi65oeuq5iu/gradle-8.7/lib/gradle-launcher-8.7.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.7-bin/bhs2wmbdwecv87pi65oeuq5iu/gradle-8.7/lib/agents/gradle-instrumentation-agent-8.7.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.7 /OpenSpace Space (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot · 2026-05-08T10:55:36Z

@copilot review is there any error

Reviewed the latest branch state: I don’t see a new code error in the Matrix/Convex changes. Latest completed workflow run on ticket-kan-16 is green (25551378591), and current new runs are still in progress. Current head reviewed: 45d9eda.

@copilot review

I reviewed again at HEAD 45d9eda: no additional actionable code issue found in the addressed threads. CI: last completed run is successful, and the newest runs are still in progress.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

+    /**
+     * MatrixEngine entry point for the current Convex action contract.
+     * Sends only the user message plus timeline context derived from that message.
+     */
+    public void sendMessageToClaude(
+            String userMessage,
+            ClaudeResponseCallback callback) {
+        int dailyMinutes = extractFirstInt(userMessage, DAILY_TIME_PATTERN, DEFAULT_DAILY_MINUTES, "dailyMinutes");
+        int totalDays = extractFirstInt(userMessage, TOTAL_DAYS_PATTERN, DEFAULT_TOTAL_DAYS, "totalDays");
+        sendMessageToClaude(userMessage, dailyMinutes, totalDays, callback);


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

shlokchorge · 2026-05-08T11:08:50Z

@copilot apply changes based on the comments in this thread

Agent-Logs-Url: https://github.com/openspace-inc/OpenSpace/sessions/d2364f56-6741-4d48-b160-253ec0c8a9e1 Co-authored-by: shlokchorge <224512884+shlokchorge@users.noreply.github.com>

Copilot · 2026-05-08T11:13:52Z

@copilot apply changes based on the comments in this thread

Applied the thread feedback in commit fa0717e.

Fixes included: removed duplicate sendMessageToClaude(String, callback) signature conflict, restored explicit systemPrompt + userMessage + dailyMinutes + totalDays overload usage in MatrixEngine, added missing ArrayList import, and updated Convex action args to accept optional systemPrompt and pass it through so Matrix JSON instructions can take effect.

No UI changes in this update.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

dl.google.com
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.7-bin/bhs2wmbdwecv87pi65oeuq5iu/gradle-8.7/lib/gradle-launcher-8.7.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.7-bin/bhs2wmbdwecv87pi65oeuq5iu/gradle-8.7/lib/agents/gradle-instrumentation-agent-8.7.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.7 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

feat(matrix): MatrixEngine pipeline + system/user prompt split

64b9c67

Copilot AI review requested due to automatic review settings May 8, 2026 09:47

Copilot started reviewing on behalf of shlokchorge May 8, 2026 09:48 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

shlokchorge and others added 4 commits May 8, 2026 15:24

Potential fix for pull request finding

17b48a0

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

96aaeb1

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

2ed0c72

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

8c913db

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot started work on behalf of shlokchorge May 8, 2026 09:59 View session

fix(matrix): normalize milestone day overflow safely

e1e5aec

Agent-Logs-Url: https://github.com/openspace-inc/OpenSpace/sessions/5feba14b-fa98-4c8e-a695-06906f047ed3 Co-authored-by: shlokchorge <224512884+shlokchorge@users.noreply.github.com>

Copilot finished work on behalf of shlokchorge May 8, 2026 10:05

Copilot started work on behalf of shlokchorge May 8, 2026 10:42 View session

fix(matrix): set parentGoalId on generated milestones

52bbb8f

Agent-Logs-Url: https://github.com/openspace-inc/OpenSpace/sessions/c366579a-c32c-4480-92c8-f46f945b16f3 Co-authored-by: shlokchorge <224512884+shlokchorge@users.noreply.github.com>

Copilot finished work on behalf of shlokchorge May 8, 2026 10:46

Copilot started work on behalf of shlokchorge May 8, 2026 10:46 View session

Copilot AI and others added 2 commits May 8, 2026 10:48

fix(matrix): align Convex payload and close helper executors

6606d35

Agent-Logs-Url: https://github.com/openspace-inc/OpenSpace/sessions/19d0b5fa-446e-4a03-98a3-5cb25c8cc2bf Co-authored-by: shlokchorge <224512884+shlokchorge@users.noreply.github.com>

refactor(convex): extract parsing patterns and defaults

1b0ebfe

Agent-Logs-Url: https://github.com/openspace-inc/OpenSpace/sessions/19d0b5fa-446e-4a03-98a3-5cb25c8cc2bf Co-authored-by: shlokchorge <224512884+shlokchorge@users.noreply.github.com>

Copilot AI and others added 2 commits May 8, 2026 10:51

chore(convex): log defaults when timeline context parsing falls back

bb4df14

Agent-Logs-Url: https://github.com/openspace-inc/OpenSpace/sessions/19d0b5fa-446e-4a03-98a3-5cb25c8cc2bf Co-authored-by: shlokchorge <224512884+shlokchorge@users.noreply.github.com>

fix(convex): add explicit timeline-context overload for matrix calls

45d9eda

Agent-Logs-Url: https://github.com/openspace-inc/OpenSpace/sessions/19d0b5fa-446e-4a03-98a3-5cb25c8cc2bf Co-authored-by: shlokchorge <224512884+shlokchorge@users.noreply.github.com>

Copilot finished work on behalf of shlokchorge May 8, 2026 10:54

Copilot started work on behalf of shlokchorge May 8, 2026 10:54 View session

shlokchorge requested a review from Copilot May 8, 2026 10:54

Copilot started reviewing on behalf of shlokchorge May 8, 2026 10:55 View session

Copilot finished work on behalf of shlokchorge May 8, 2026 10:56

Copilot AI reviewed May 8, 2026

View reviewed changes

Comment thread app/src/main/java/com/example/iaso/ConvexApiHelper.java Outdated

Comment thread app/src/main/java/com/example/iaso/matrix/MatrixEngine.java

Comment thread app/src/main/java/com/example/iaso/matrix/MatrixEngine.java

shlokchorge and others added 2 commits May 8, 2026 16:31

Potential fix for pull request finding

2b8fc00

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

a6252c4

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

shlokchorge requested a review from Copilot May 8, 2026 11:03

Copilot started reviewing on behalf of shlokchorge May 8, 2026 11:04 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Potential fix for pull request finding

5483b99

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot started work on behalf of shlokchorge May 8, 2026 11:09 View session

fix(matrix): restore system prompt passthrough and helper overloads

fa0717e

Agent-Logs-Url: https://github.com/openspace-inc/OpenSpace/sessions/d2364f56-6741-4d48-b160-253ec0c8a9e1 Co-authored-by: shlokchorge <224512884+shlokchorge@users.noreply.github.com>

Copilot finished work on behalf of shlokchorge May 8, 2026 11:14

shlokchorge requested a review from Copilot May 8, 2026 11:17

Copilot started reviewing on behalf of shlokchorge May 8, 2026 11:18 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Comment thread convex/workhorse.ts

Comment thread app/src/main/java/com/example/iaso/ConvexApiHelper.java

Comment thread app/src/main/java/com/example/iaso/ConvexApiHelper.java Outdated

Potential fix for pull request finding

5ac6057

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

shlokchorge requested a review from Copilot May 8, 2026 11:31

Copilot started reviewing on behalf of shlokchorge May 8, 2026 11:31 View session

Copilot AI reviewed May 8, 2026

Conversation

shlokchorge commented May 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

shlokchorge May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shlokchorge May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented May 8, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI commented May 8, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

shlokchorge commented May 8, 2026

Uh oh!

shlokchorge commented May 8, 2026

Uh oh!

Copilot AI commented May 8, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shlokchorge commented May 8, 2026

Uh oh!

Copilot AI commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 8, 2026 •

edited

Loading

Copilot AI commented May 8, 2026 •

edited

Loading