Conversation
rubiin
requested review from
aj3sh and
sugat009
and removed request for
sugat009
|
Additionally we could add it to the CI as a step |
|
What went wrong with eslint? Why oxlint is necessary? And why multiple linters? Could you please provide more details of the PR on the PR description. |
|
Eslint is slow in cases and the changes from one major semvar to another is a nightmare. Oxlint is a high-performance JavaScript/TypeScript linter designed to replace ESLint, offering significant speed improvements (50-100x faster) by being built in Rust. Also oxlint is eslint compatible, |
sugat009
left a comment
sugat009
left a comment
There was a problem hiding this comment.
Review
issue (blocking): CI is failing — oxlint.config.ts was not formatted with Prettier
The Prettier check step fails because the config file has formatting issues. Run npx prettier --write oxlint.config.ts before pushing.
suggestion: consider adding CI integration in this PR as well — it is a small change and would ship oxlint as a complete, usable setup. Either a dedicated CI step or updating the lint script (e.g. "lint": "prettier --check . && oxlint") would work.
Co-authored-by: Copilot <copilot@github.com>
| export default defineConfig({ | ||
| plugins: ['import', 'typescript', 'unicorn'], | ||
|
|
||
| ignorePatterns: ['**/*.{mjs,cjs,js,d.ts,d.mts}', '.next'], |
There was a problem hiding this comment.
suggestion: Let's ignore the whole dist/ directory. Also remove the .next, not relevant to this project.
Could you please update the PR description? |
|
The commit message is invalid, this is not a feature (feat). I prefer using |
rubiin
changed the title
|
done |
3 participants
Description
Eslint is slow in cases and the changes from one major semvar to another is a nightmare. Oxlint is a high-performance JavaScript/TypeScript linter designed to replace ESLint, offering significant speed improvements (50-100x faster) by being built in Rust. Also oxlint is eslint compatible,
You could read more on here oxc.rs/docs/guide/usage/linter.html
Related Issue
[If your pull request is related to an existing issue, reference it here using the format "Fixes #issue_number".]
Type of Change
Please mark the appropriate option below to describe the type of change your pull request introduces:
Checklist
README.md.Additional Notes
[Add any additional notes or context that you think the reviewers should know about.]
By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.