Skip to content

Fix bug in DeGrooteFregly2016Muscle related to function-local statics for activation dynamics parameters - #4490

Open
nickbianco wants to merge 1 commit into
mainfrom
moco_activation_time_constant_bug
Open

nickbianco wants to merge 1 commit into
mainfrom
moco_activation_time_constant_bug

Conversation

@nickbianco

@nickbianco nickbianco commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Fixes issue #4470

Brief summary of changes

Removes thestatic keywords for function-local variables assigned based on the activation_time_constant, deactivation_time_constant, and activation_dynamics_smoothing properties. Previous to this change, the variables would take on values of the first muscle evaluated in a process for all muscles, ignoring later changes to these properties.

Testing I've completed

Added test "DeGrooteFregly2016Muscle uses per-muscle time constants values" to testDeGrooteFregly2016Musce.cpp.

Looking for feedback on...

AI/LLM use

Use Claude Code to confirm the static keyword bug and implement the unit test.

CHANGELOG.md (choose one)

  • updated.

Please review the CONTRIBUTING.md file for detailed contributing guidelines.


This change is Reviewable

@nickbianco
nickbianco force-pushed the moco_activation_time_constant_bug branch from 39f50d2 to 887af79 Compare November 18, 2026 19:18

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant