Repository navigation
Fix bug in DeGrooteFregly2016Muscle related to function-local statics for activation dynamics parameters - #4490
Open
nickbianco wants to merge 1 commit into
Open
nickbianco wants to merge 1 commit into
nickbianco wants to merge 1 commit into
Conversation
… for activation dynamics parameters
nickbianco
force-pushed
the
moco_activation_time_constant_bug
branch
from
November 18, 2026 19:18
39f50d2 to
887af79
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #4470
Brief summary of changes
Removes the
statickeywords for function-local variables assigned based on theactivation_time_constant,deactivation_time_constant, andactivation_dynamics_smoothingproperties. Previous to this change, the variables would take on values of the first muscle evaluated in a process for all muscles, ignoring later changes to these properties.Testing I've completed
Added test "DeGrooteFregly2016Muscle uses per-muscle time constants values" to
testDeGrooteFregly2016Musce.cpp.Looking for feedback on...
AI/LLM use
Use Claude Code to confirm the
statickeyword bug and implement the unit test.CHANGELOG.md (choose one)
Please review the CONTRIBUTING.md file for detailed contributing guidelines.
This change is