Skip to content

Fix bugs and add reversed joint support in SimulationUtilities::findJointsBetweenPhysicalFrames() - #4488

Open
nickbianco wants to merge 1 commit into
mainfrom
find_joints_bug
Open

nickbianco wants to merge 1 commit into
mainfrom
find_joints_bug

Conversation

@nickbianco

@nickbianco nickbianco commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Fixes issue #4484

Brief summary of changes

This change redefines the behavior of SimulationUtilities::findJointsBetweenPhysicalFrames() to both fix a bug related to joints between double-counted (#4484) and also provide support for model topologies with reversed joints.

In the new implementation, the utility constructs an undirected graph of the model's topology which is searched until the list of Joints connecting the first and second frame are found. The graph is undirected since a Joint may have either the typical forward definition or may be reversed, where the convention of the parent and child frames are swapped. By construction, the list of Joints cannot have a duplicate, and a post-hoc check is performed to ensure that all Joints in the list are not part of a kinematic loop.

Testing I've completed

Added relevant subtests to test "findJointsBetweenPhysicalFrames" in testSimulationUtilities.cpp.

Looking for feedback on...

AI/LLM use

Used Claude Code to identify sources of bugs and implement undirected graph approach. Used Codex for local code review.

CHANGELOG.md (choose one)

  • updated.

Please review the CONTRIBUTING.md file for detailed contributing guidelines.


This change is Reviewable

@nickbianco
nickbianco force-pushed the find_joints_bug branch 2 times, most recently from 10507ad to 24055ce Compare November 17, 2026 21:08
@nickbianco
nickbianco marked this pull request as ready for review November 17, 2026 21:16
@nickbianco
nickbianco force-pushed the find_joints_bug branch 2 times, most recently from ce35341 to 93e2ad9 Compare November 18, 2026 14:38
…tionUtilities::findJointsBetweenPhysicalFrames()

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant