Repository navigation
Fix bugs and add reversed joint support in SimulationUtilities::findJointsBetweenPhysicalFrames() - #4488
Open
nickbianco wants to merge 1 commit into
Open
Fix bugs and add reversed joint support in SimulationUtilities::findJointsBetweenPhysicalFrames()#4488nickbianco wants to merge 1 commit into
SimulationUtilities::findJointsBetweenPhysicalFrames()#4488nickbianco wants to merge 1 commit into
Conversation
nickbianco
force-pushed
the
find_joints_bug
branch
2 times, most recently
from
November 17, 2026 21:08
10507ad to
24055ce
Compare
nickbianco
marked this pull request as ready for review
November 17, 2026 21:16
nickbianco
force-pushed
the
find_joints_bug
branch
2 times, most recently
from
November 18, 2026 14:38
ce35341 to
93e2ad9
Compare
…tionUtilities::findJointsBetweenPhysicalFrames()
nickbianco
force-pushed
the
find_joints_bug
branch
from
November 18, 2026 17:39
93e2ad9 to
eb2b748
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #4484
Brief summary of changes
This change redefines the behavior of
SimulationUtilities::findJointsBetweenPhysicalFrames()to both fix a bug related to joints between double-counted (#4484) and also provide support for model topologies with reversed joints.In the new implementation, the utility constructs an undirected graph of the model's topology which is searched until the list of
Joints connecting the first and second frame are found. The graph is undirected since aJointmay have either the typical forward definition or may be reversed, where the convention of the parent and child frames are swapped. By construction, the list ofJoints cannot have a duplicate, and a post-hoc check is performed to ensure that allJoints in the list are not part of a kinematic loop.Testing I've completed
Added relevant subtests to test "findJointsBetweenPhysicalFrames" in
testSimulationUtilities.cpp.Looking for feedback on...
AI/LLM use
Used Claude Code to identify sources of bugs and implement undirected graph approach. Used Codex for local code review.
CHANGELOG.md (choose one)
Please review the CONTRIBUTING.md file for detailed contributing guidelines.
This change is