Skip to content

Conversation

@ctrought
Copy link

Adds per route http keep alive timeout annotation.

kind: Route
apiVersion: route.openshift.io/v1
metadata:
  name: nginx
  namespace: aiocptools
  annotations:
    haproxy.router.openshift.io/timeout-http-keep-alive: 30m

HAproxy config

backend be_edge_http:namesapce:nginx
  mode http
  option redispatch
  option forwardfor
  balance random
  timeout http-keep-alive 30m                    <---

  timeout check 5000ms
  http-request add-header X-Forwarded-Host %[req.hdr(host)]
  http-request add-header X-Forwarded-Port %[dst_port]
  http-request add-header X-Forwarded-Proto http if !{ ssl_fc }
  http-request add-header X-Forwarded-Proto https if { ssl_fc }
  http-request add-header X-Forwarded-Proto-Version h2 if { ssl_fc_alpn -i h2 }
  http-request add-header Forwarded for=%[src];host=%[req.hdr(host)];proto=%[req.hdr(X-Forwarded-Proto)]

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 21, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2026

Hi @ctrought. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from Thealisyed and knobunc January 21, 2026 05:58
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign frobware for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alebedev87
Copy link
Contributor

Just for info and may be this can address (partially) your need: recently we implemented an API field in IngressController API to fine tune http-keep alive timeout for the whole ingresscontroller: link to api field.

@ctrought
Copy link
Author

Just for info and may be this can address (partially) your need: recently we implemented an API field in IngressController API to fine tune http-keep alive timeout for the whole ingresscontroller: link to api field.

Thank you! Definitely an option, though was hoping to be able to set per route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants