-
Notifications
You must be signed in to change notification settings - Fork 136
NE-2468: Migrate away from deprecated ioutil #693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@sebrandon1: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/assign |
|
/assign @davidesalerno |
|
@sebrandon1: This pull request references NE-2468 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
cc @ShudiLi |
|
/label qe-approved |
|
@sebrandon1: This pull request references NE-2468 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ShudiLi: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ioutilhas been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutilTracking issue: redhat-best-practices-for-k8s/telco-bot#52
Modernization of file and stream operations:
Replaced all instances of
ioutil.ReadFileandioutil.WriteFilewithos.ReadFileandos.WriteFilein production code and tests, ensuring up-to-date file I/O operations. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]Updated usage of
ioutil.TempFileandioutil.TempDirtoos.CreateTempandos.MkdirTempfor creating temporary files and directories. [1] [2] [3]Changed
ioutil.NopCloserandioutil.Discardto theirioequivalents (io.NopCloser,io.Discard) for stream handling. [1] [2]Codebase cleanup:
ioutilimports and replaced them withosandiowhere necessary across all affected files. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]These updates ensure the codebase is compatible with the latest Go standards and avoids deprecated APIs.