Skip to content

Move usernamespace test into longrunning test suite#75030

Open
ngopalak-redhat wants to merge 1 commit intoopenshift:mainfrom
ngopalak-redhat:ngopalak/remove_usernamespace
Open

Move usernamespace test into longrunning test suite#75030
ngopalak-redhat wants to merge 1 commit intoopenshift:mainfrom
ngopalak-redhat:ngopalak/remove_usernamespace

Conversation

@ngopalak-redhat
Copy link
Copy Markdown
Contributor

@ngopalak-redhat ngopalak-redhat commented Feb 18, 2026

Remove the job periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-usernamespace

It will be included in long running test suite: openshift/origin#30792
Also adding the rename to origin: openshift-eng/ci-test-mapping#614

The plan is to first remove it from this release repo and then merge above PRs

Summary by CodeRabbit

  • Chores
    • Removed optional GCP-based end-to-end test configuration from the CI/CD pipeline across multiple manifest files.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 18, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/assign @bitoku

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2026
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 18, 2026
@bitoku
Copy link
Copy Markdown
Contributor

bitoku commented Feb 18, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2026
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2026
@cpmeadors
Copy link
Copy Markdown
Contributor

/testwith openshift/release/main/e2e-aws-disruptive-longrunning openshift/origin#30792

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 24, 2026

@cpmeadors, testwith: could not generate prow job. ERROR:

BUG: test 'e2e-aws-disruptive-longrunning' not found in injected config

@miyadav
Copy link
Copy Markdown
Member

miyadav commented Feb 24, 2026

/testwith periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning openshift/origin/pull/30792 openshift-eng/ci-test-mapping#614

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 24, 2026

@miyadav, testwith: Error processing request. ERROR:

could not determine job runs: requested job is invalid. needs to be formatted like: <org>/<repo>/<branch>/<variant?>/<job>. instead it was: periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 24, 2026

@miyadav: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

1 similar comment
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 24, 2026

@miyadav: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@ngopalak-redhat ngopalak-redhat force-pushed the ngopalak/remove_usernamespace branch from bbcbb7c to b8e079c Compare March 16, 2026 07:50
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2026
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2026
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 16, 2026
@ngopalak-redhat ngopalak-redhat force-pushed the ngopalak/remove_usernamespace branch from 57da6ba to ca0e465 Compare March 24, 2026 08:42
@ngopalak-redhat ngopalak-redhat force-pushed the ngopalak/remove_usernamespace branch from ca0e465 to b3e6a94 Compare April 16, 2026 06:46
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 26e4adce-016d-476f-98c6-042c3baeea49

📥 Commits

Reviewing files that changed from the base of the PR and between 5e46ebf and b3e6a94.

📒 Files selected for processing (4)
  • ci-operator/config/openshift-priv/origin/openshift-priv-origin-main.yaml
  • ci-operator/config/openshift/origin/openshift-origin-main.yaml
  • ci-operator/jobs/openshift-priv/origin/openshift-priv-origin-main-presubmits.yaml
  • ci-operator/jobs/openshift/origin/openshift-origin-main-presubmits.yaml
💤 Files with no reviewable changes (4)
  • ci-operator/config/openshift/origin/openshift-origin-main.yaml
  • ci-operator/config/openshift-priv/origin/openshift-priv-origin-main.yaml
  • ci-operator/jobs/openshift/origin/openshift-origin-main-presubmits.yaml
  • ci-operator/jobs/openshift-priv/origin/openshift-priv-origin-main-presubmits.yaml

Walkthrough

Removed the e2e-gcp-ovn-usernamespace test job configuration from CI/CD pipeline definitions across openshift and openshift-priv repositories. This includes removing test entries from configuration files and corresponding presubmit job definitions with associated GCP cluster profiles, environment settings, and workflow triggers.

Changes

Cohort / File(s) Summary
Test Configuration Files
ci-operator/config/openshift-priv/origin/openshift-priv-origin-main.yaml, ci-operator/config/openshift/origin/openshift-origin-main.yaml
Removed optional E2E test entry e2e-gcp-ovn-usernamespace including cluster profile, FEATURE_SET, TEST_SUITE, observers configuration, and workflow settings.
Presubmit Job Definitions
ci-operator/jobs/openshift-priv/origin/openshift-priv-origin-main-presubmits.yaml, ci-operator/jobs/openshift/origin/openshift-origin-main-presubmits.yaml
Removed presubmit job declarations for pull-ci-openshift-*-origin-main-e2e-gcp-ovn-usernamespace including Kubernetes agent configuration, branch filters, cluster assignments, and test trigger regex patterns.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main objective: moving the usernamespace test into the longrunning test suite, which aligns with the changeset that removes the e2e-gcp-ovn-usernamespace test entries across four configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI configuration YAML files, not Ginkgo test code; custom check for stable test names does not apply to CI configuration changes.
Test Structure And Quality ✅ Passed Pull request only modifies YAML CI/CD configuration files with no Go test file changes, making this Ginkgo test code quality check not applicable.
Microshift Test Compatibility ✅ Passed This PR only removes CI job configuration entries from YAML files in the openshift/release repository. No new Ginkgo e2e test code is being added, so the MicroShift Test Compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR removes existing CI test configurations without adding new Ginkgo e2e tests, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only removes CI test job definitions; no deployment manifests, operators, controllers, or scheduling constraints are added or modified.
Ote Binary Stdout Contract ✅ Passed The OTE Binary Stdout Contract check is not applicable to this pull request. This PR only modifies CI/CD configuration files in YAML format and does not modify any Go source code or OTE binary implementations.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR removes CI configuration entries for e2e-gcp-ovn-usernamespace test; no new Ginkgo e2e tests are added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot openshift-merge-bot bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 16, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@ngopalak-redhat: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 16, 2026

@ngopalak-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

@bitoku Can you review this again?
My goal is to remove the job from the next release onwards.

@bitoku
Copy link
Copy Markdown
Contributor

bitoku commented Apr 16, 2026

I'm not sure what's the right order to merge.
Should openshift/origin#30792 be merged first?

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

@bitoku If we merge the origin change first we'll see failures/false positives in the job. If we merge this it will stop running and then we can merge the origin test case.

@bitoku
Copy link
Copy Markdown
Contributor

bitoku commented Apr 16, 2026

/lgtm

make sense! thanks

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bitoku, ngopalak-redhat
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants