Skip to content

[WIP] SDCICD-1801 pdhelper claude skill#3174

Open
ritmun wants to merge 1 commit intoopenshift:mainfrom
ritmun:pdhelper-skill
Open

[WIP] SDCICD-1801 pdhelper claude skill#3174
ritmun wants to merge 1 commit intoopenshift:mainfrom
ritmun:pdhelper-skill

Conversation

@ritmun
Copy link
Copy Markdown
Contributor

@ritmun ritmun commented Mar 25, 2026

  • see pdhelper help/pdhelper how to list all available commands
  • document team ownership mapping with 8 teams and their components
  • you should have local clone of app-interface.

🤖 Generated with https://claude.com/claude-code

Co-Authored-By: Claude noreply@anthropic.com

Example

pdhelper team rocket

image

@openshift-ci-robot
Copy link
Copy Markdown

There are test jobs defined for this repository which are not configured to run automatically. Comment /test ? to see a list of all defined jobs. Review these jobs and use /test <job> to manually trigger jobs most likely to be impacted by the proposed changes.Comment /pipeline required to trigger all required & necessary jobs.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 25, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: f12434d0-6bca-46e6-aab9-60beb20c8afe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ritmun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
.claude/skills/pdhelper.md (1)

25-33: Add language identifier to code block.

The example permission request block lacks a language identifier. While this is documentation rather than executable code, adding an identifier improves clarity.

📝 Proposed fix
-```
+```text
 To help you track commit deployments, I need permission for this session to:
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.claude/skills/pdhelper.md around lines 25 - 33, The fenced code block
starting with ``` that contains the permission request should include a language
identifier for clarity; update the opening fence from ``` to ```text (i.e.,
change the first triple-backtick that precedes "To help you track commit
deployments, I need permission for this session to:" to ```text) so the block is
explicitly marked as plain text.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.claude/skills.json:
- Line 9: Add a trailing newline at the end of the file .claude/skills.json so
the file ends with a newline character (i.e., ensure the final character before
EOF is '\n'); simply update the file's end-of-file to include the missing
newline.

In @.claude/skills/pdhelper.md:
- Line 633: The file ending line "App file:
`services/{service-name}/{operator-name}/app.yml`" is missing a trailing
newline; update the file `.claude/skills/pdhelper.md` to ensure the last
character is a newline (add a single trailing newline at EOF) so the file ends
with a newline character per convention.
- Line 55: The "Available teams: `rocket`, `aurora`, `thor`, `hulk`, `orange`,
`security`, `rosa`" entry is missing two teams (`fedramp`, `lpsre`) that are
referenced elsewhere; update that string to include `fedramp` and `lpsre` so it
reads e.g. "Available teams: `rocket`, `aurora`, `thor`, `hulk`, `orange`,
`security`, `rosa`, `fedramp`, `lpsre`" and scan the document for other
occurrences of the team list to make sure all references are consistent.
- Around line 585-589: The ownership list in .claude/skills/pdhelper.md
currently ends with an ambiguous note "(and all other team's repos)"; replace
that ambiguity by either enumerating every ROSA-owned component or by replacing
the phrase with an explicit sentence stating that Team ROSA owns all remaining
repos and why. Specifically update the list entries (e.g., clusterimagesets,
osd-gcp-marketplace-config, rosa-marketplace-release-generator) to include all
remaining component names OR change the trailing line to a clear statement like
"Team ROSA owns all other unlisted repositories for X reason" so queries against
the ROSA ownership list are deterministic.

---

Nitpick comments:
In @.claude/skills/pdhelper.md:
- Around line 25-33: The fenced code block starting with ``` that contains the
permission request should include a language identifier for clarity; update the
opening fence from ``` to ```text (i.e., change the first triple-backtick that
precedes "To help you track commit deployments, I need permission for this
session to:" to ```text) so the block is explicitly marked as plain text.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 1b72a979-d31d-433d-805c-83bb4d1ffaad

📥 Commits

Reviewing files that changed from the base of the PR and between 2aedfe3 and 8be0dc0.

📒 Files selected for processing (2)
  • .claude/skills.json
  • .claude/skills/pdhelper.md

@ritmun ritmun force-pushed the pdhelper-skill branch 7 times, most recently from 55dd066 to 06d7b77 Compare March 25, 2026 18:52
  - see pdhelper help/pdhelper how to list all available commands
  - document team ownership mapping with 8 teams and their components

  🤖 Generated with https://claude.com/claude-code

  Co-Authored-By: Claude noreply@anthropic.com
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 25, 2026

@ritmun: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ritmun ritmun changed the title SDCICD-1801 pdhelper claude skill [WIP] SDCICD-1801 pdhelper claude skill Mar 26, 2026
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants