Skip to content

TRT-2808: admit and extract non-payload 4.20#31387

Open
danchild wants to merge 3 commits into
openshift:release-4.20from
shiftstack:admit-extract-nonpayload-ote-binaries-4.20
Open

TRT-2808: admit and extract non-payload 4.20#31387
danchild wants to merge 3 commits into
openshift:release-4.20from
shiftstack:admit-extract-nonpayload-ote-binaries-4.20

Conversation

@danchild

@danchild danchild commented Jul 14, 2026

Copy link
Copy Markdown
Member

Continues work performed in #30863.

Our team is migrating openshift/openstack-test to use the OTE framework, including releases 4.22 to 4.19. The extension-admission subcommand used to install the TestExtension CRD needs to be backported in order to complete the migration.

@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2026
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a70c66ee-13e1-46f3-9c3f-fd56e6c3272c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@danchild danchild changed the title admit extract nonpayload ote binaries 4.20 TRT-2295: admit and extract non-payload 4.20 Jul 15, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 15, 2026

Copy link
Copy Markdown

@danchild: This pull request references TRT-2295 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.z" version, but no target version was set.

Details

In response to this:

  • admit and extract non-payload OTE binaries, and allow for a new subcommand to install the TestExtension CRD and apply the matching CR
  • implement requested changes
  • rename file and save artifacts from CRD installation and CR creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 15, 2026
@danchild

Copy link
Copy Markdown
Member Author

/assign @smg247

@danchild
danchild marked this pull request as ready for review July 15, 2026 14:28
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2026
@openshift-ci
openshift-ci Bot requested review from ironcladlou and sjenning July 15, 2026 14:29
@danchild

Copy link
Copy Markdown
Member Author

/test e2e-vsphere-ovn-upi

@danchild

Copy link
Copy Markdown
Member Author

/test e2e-gcp-ovn

@danchild

Copy link
Copy Markdown
Member Author

/test e2e-aws-ovn-fips

@ekuris-redhat

Copy link
Copy Markdown

/test e2e-gcp-ovn

Comment thread pkg/test/ginkgo/cmd_runsuite.go Outdated
@ekuris-redhat

Copy link
Copy Markdown

/test e2e-gcp-ovn

@danchild
danchild force-pushed the admit-extract-nonpayload-ote-binaries-4.20 branch from 579217a to ecad664 Compare July 20, 2026 18:52
Comment thread pkg/test/ginkgo/cmd_runsuite.go Outdated
@danchild
danchild force-pushed the admit-extract-nonpayload-ote-binaries-4.20 branch from ecad664 to c6af7c5 Compare July 20, 2026 19:49

@smg247 smg247 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2026
@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danchild, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2026
@danchild

Copy link
Copy Markdown
Member Author

/verified by @danchild

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 20, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@danchild: This PR has been marked as verified by @danchild.

Details

In response to this:

/verified by @danchild

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danchild danchild changed the title TRT-2295: admit and extract non-payload 4.20 TRT-2807: admit and extract non-payload 4.20 Jul 20, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 20, 2026

Copy link
Copy Markdown

@danchild: This pull request references TRT-2807 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.z" version, but no target version was set.

Details

In response to this:

Continues work performed in #30863.

Our team is migrating openshift/openstack-test to use the OTE framework, including releases 4.22 to 4.19. The extension-admission subcommand used to install the TestExtension CRD needs to be backported in order to complete the migration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danchild danchild changed the title TRT-2807: admit and extract non-payload 4.20 TRT-2808: admit and extract non-payload 4.20 Jul 20, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 20, 2026

Copy link
Copy Markdown

@danchild: This pull request references TRT-2808 which is a valid jira issue.

Details

In response to this:

Continues work performed in #30863.

Our team is migrating openshift/openstack-test to use the OTE framework, including releases 4.22 to 4.19. The extension-admission subcommand used to install the TestExtension CRD needs to be backported in order to complete the migration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danchild

Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Jul 20, 2026

Copy link
Copy Markdown

@danchild: This pull request references TRT-2808 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@danchild: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants