Skip to content

NO-ISSUE: Synchronize From Upstream Repositories#1299

Open
openshift-bot wants to merge 1 commit into
openshift:mainfrom
openshift-bot:synchronize-upstream
Open

NO-ISSUE: Synchronize From Upstream Repositories#1299
openshift-bot wants to merge 1 commit into
openshift:mainfrom
openshift-bot:synchronize-upstream

Conversation

@openshift-bot
Copy link
Copy Markdown
Contributor

@openshift-bot openshift-bot commented May 15, 2026

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date Commit Author Message
2026-05-14 19:31:53 operator-framework/operator-lifecycle-manager@4e18ba8 Todd Short Update google.golang.org/grpc to v1.81.1 (#3831)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/assign @openshift/openshift-team-operator-runtime

Signed-off-by: Todd Short <tshort@redhat.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 4e18ba810803ef8605eda5ae8e32a10d1d4ce578
@openshift-bot openshift-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 15, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@openshift-bot: This pull request explicitly references no jira issue.

Details

In response to this:

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date Commit Author Message
2026-05-14 19:31:53 operator-framework/operator-lifecycle-manager@4e18ba8 Todd Short Update google.golang.org/grpc to v1.81.1 (#3831)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/assign @openshift/openshift-team-operator-runtime

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 15, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: efca7f01-5d5e-47aa-aabf-5d3a52754069

📥 Commits

Reviewing files that changed from the base of the PR and between 754d45a and 0953a32.

⛔ Files ignored due to path filters (4)
  • go.sum is excluded by !**/*.sum
  • staging/operator-lifecycle-manager/go.sum is excluded by !**/*.sum
  • vendor/google.golang.org/grpc/version.go is excluded by !**/vendor/**, !vendor/**
  • vendor/modules.txt is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (2)
  • go.mod
  • staging/operator-lifecycle-manager/go.mod

Walkthrough

Update google.golang.org/grpc from v1.81.0 to v1.81.1 in the root and operator-lifecycle-manager module go.mod files to apply a patch version bump consistently across the project.

Changes

gRPC Dependency Update

Layer / File(s) Summary
Update google.golang.org/grpc to v1.81.1
go.mod, staging/operator-lifecycle-manager/go.mod
Indirect and direct google.golang.org/grpc dependencies are bumped from v1.81.0 to v1.81.1 in both module files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 warning)

Check name Status Explanation Resolution
Stable And Deterministic Test Names ❌ Error PR introduces dynamic test names using fmt.Sprintf with variables. Found in catalog_e2e_test.go: It(fmt.Sprintf("delete registry %s...", npType)) violates stable test name requirement. Remove fmt.Sprintf and variable interpolation from test names. Use static descriptive strings like "should delete registry network policy" instead of injecting npType variable.
Topology-Aware Scheduling Compatibility ⚠️ Warning Deployment manifests use nodeSelector targeting node-role.kubernetes.io/master. This breaks on HyperShift (External topology) where no control-plane nodes exist in hosted cluster. Remove node-role.kubernetes.io/master nodeSelector from olm-operator and catalog-operator deployments, or add topology-aware logic to detect and handle HyperShift/External topologies separately.
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'NO-ISSUE: Synchronize From Upstream Repositories' accurately describes the main purpose of the PR, which is to synchronize staging and vendor directories from upstream repositories (specifically pulling in a gRPC v1.81.1 update).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Test Structure And Quality ✅ Passed This PR contains only dependency version updates in go.mod files. No test code was added or modified. The custom check for Ginkgo test structure and quality is not applicable to this PR.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. Changes are limited to dependency version bumps in go.mod files. The custom check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only updates go.mod dependencies (google.golang.org/grpc v1.81.0 → v1.81.1) with synchronized upstream code. No new Ginkgo e2e tests are added, making this check not applicable.
Ote Binary Stdout Contract ✅ Passed PR only bumps grpc v1.81.0→v1.81.1 in go.mod (patch version, no code changes). OTE binary (tests-extension/cmd/main.go) doesn't use grpc directly and has no stdout writes in main().
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only updates google.golang.org/grpc v1.81.0→v1.81.1 in go.mod files. No new Ginkgo tests added. Check applies only when new tests are added, not applicable here.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from bentito and camilamacedo86 May 15, 2026 00:04
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 15, 2026

@openshift-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-upgrade-ovn-single-node 0953a32 link false /test e2e-aws-upgrade-ovn-single-node
ci/prow/unit-olm 0953a32 link true /test unit-olm
ci/prow/e2e-gcp-ovn 0953a32 link true /test e2e-gcp-ovn
ci/prow/okd-scos-images 0953a32 link true /test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants