WIP: Tests: Add wait for cluster API to become available#2102
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe ChangesCluster API Reachability Gate with Configurable Timeouts
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
6aab7ad to
e41d0dd
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/support/global-setup.ts`:
- Around line 20-38: The global setup can block for approximately 95 minutes
when the cluster is unreachable because the oc function uses a 180-second
timeout per attempt, and with 30 retries at 10-second intervals, the failure
path takes too long. Add a per-attempt timeout parameter to the oc(['version'])
call to bound how long each probe waits, and reduce either MAX_RETRIES or
RETRY_DELAY_S (or both) to decrease the total wall time before CI fails when the
cluster is actually unavailable. This ensures the setup fails fast in failure
scenarios rather than blocking for extended periods.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 68bcdc6d-c0d7-4529-8003-5e06fcb2d61c
📒 Files selected for processing (1)
tests/support/global-setup.ts
6a9e109 to
0f1360f
Compare
0f1360f to
0c2b81d
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary by CodeRabbit
oc versionup to 120 times with a 10-second delay, logging warnings on intermediate failures and re-throwing the final error if still unreachable.