Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .tekton/integration-tests/lightspeed-console-pre-commit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ spec:
env:
- name: COMMIT_SHA
value: $(params.commit)
image: mcr.microsoft.com/playwright:v1.60.0-noble
image: mcr.microsoft.com/playwright:v1.61.0-noble

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

for f in package.json package-lock.json pnpm-lock.yaml yarn.lock .tekton/integration-tests/lightspeed-console-pre-commit.yaml; do
  [ -f "$f" ] || continue
  rg -n '"`@playwright/test`"|mcr\.microsoft\.com/playwright' "$f"
done

Repository: openshift/lightspeed-console

Length of output: 282


Align Playwright Docker image version with @playwright/test package.

The repo pins @playwright/test to 1.60.0, but the Docker images in the Tekton pipeline are set to v1.61.0-noble on both lines 149 and 239. Playwright requires matching versions between the Docker image and the test package, or browser executables will not be found. Either bump the package.json version to match the image or keep both image references on v1.60.0.

πŸ€– Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.tekton/integration-tests/lightspeed-console-pre-commit.yaml at line 149,
There is a version mismatch between the Playwright Docker image and the
`@playwright/test` package that will cause browser executable issues. The Docker
image reference uses v1.61.0-noble while the package is pinned to 1.60.0. Update
either the `@playwright/test` package version in package.json to 1.61.0 to match
the Docker image, or revert both Docker image references (on lines 149 and 239)
from v1.61.0-noble back to v1.60.0 to match the package version. Ensure the
versions are consistent across all references.

resources:
limits:
memory: 4Gi
Expand Down Expand Up @@ -236,7 +236,7 @@ spec:
resources:
limits:
memory: 8Gi
image: mcr.microsoft.com/playwright:v1.60.0-noble
image: mcr.microsoft.com/playwright:v1.61.0-noble
script: |
echo "COMMIT_SHA: ${COMMIT_SHA}"
echo "BASE_URL: ${BASE_URL}"
Expand Down