4.19: Tests: Fix goToPodDetails helper flakiness by kyoto · Pull Request #2081 · openshift/lightspeed-console

kyoto · 2026-06-16T05:55:01Z

Manual backport of #2076

Summary by CodeRabbit

Tests
- Improved test helper to better target specific pod entries by filtering and waiting for visibility, enhancing test reliability and reducing flakiness.

coderabbitai · 2026-06-16T05:55:13Z

📝 Walkthrough

Walkthrough

The goToPodDetails helper in the test file is updated to locate the pod link by filtering resource rows to those containing the target podName, waiting up to 30 seconds for the first match to become visible, then clicking it. The previous approach clicked the first generic resource name link after asserting overall row count.

Changes

Pod Details Navigation Fix

Layer / File(s)	Summary
goToPodDetails pod-specific link selection `tests/tests/lightspeed.spec.ts`	Replaces generic first-link click (with row-count assertion) with a `podName`-filtered resource row lookup, a 30s visibility wait, and a targeted click on the matched link.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

openshift/lightspeed-console#2076: Modifies the same goToPodDetails helper in tests/tests/lightspeed.spec.ts to filter pods by podName and wait for the specific link, the same pattern introduced here.

Suggested reviewers

joshuawilson
JoaoFula

Poem

🐇 No more grabbing the first link in sight,
The rabbit now filters by name — just right!
podName is matched, the row is found,
A 30-second wait, then click! Safe and sound.
Precision over guessing, every test night. ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically identifies the main change: fixing flakiness in the goToPodDetails test helper function.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-06-16T05:55:38Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-06-16T05:55:39Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/tests/lightspeed.spec.ts`:
- Around line 37-39: The test is currently clicking on the resource row
container itself (the result of page.locator(resourceRows).filter({ hasText:
podName })), which can lead to flaky behavior. Instead of clicking link.first()
directly, locate the resource-name anchor element within the filtered row and
click that specific anchor element to ensure reliable navigation. This targets
the actual clickable link rather than the container row.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5d0fdbc2-849e-4feb-ac5d-4fc7e0d5845e

📥 Commits

Reviewing files that changed from the base of the PR and between 946c356 and edf87fa.

📒 Files selected for processing (1)

tests/tests/lightspeed.spec.ts

coderabbitai · 2026-06-16T05:57:12Z

+  const link = page.locator(resourceRows).filter({ hasText: podName });
+  await expect(link.first()).toBeVisible({ timeout: 30_000 });
+  await link.first().click();


⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Click the pod link element, not the row container.

On Line 37-39, link resolves to matching resource rows and the test clicks the row itself. That can still be flaky/non-navigational. Target the resource-name anchor within the filtered row and click that element explicitly.

Proposed fix

- const link = page.locator(resourceRows).filter({ hasText: podName }); - await expect(link.first()).toBeVisible({ timeout: 30_000 }); - await link.first().click(); + const row = page.locator(resourceRows).filter({ hasText: podName }).first(); + const link = row.locator('a.co-resource-item__resource-name').first(); + await expect(link).toBeVisible({ timeout: 30_000 }); + await link.click();

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

const link = page.locator(resourceRows).filter({ hasText: podName });

await expect(link.first()).toBeVisible({ timeout: 30_000 });

await link.first().click();

const row = page.locator(resourceRows).filter({ hasText: podName }).first();

const link = row.locator('a.co-resource-item__resource-name').first();

await expect(link).toBeVisible({ timeout: 30_000 });

await link.click();

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/tests/lightspeed.spec.ts` around lines 37 - 39, The test is currently clicking on the resource row container itself (the result of page.locator(resourceRows).filter({ hasText: podName })), which can lead to flaky behavior. Instead of clicking link.first() directly, locate the resource-name anchor element within the filtered row and click that specific anchor element to ensure reliable navigation. This targets the actual clickable link rather than the container row.

kyoto · 2026-06-16T06:28:24Z

/retest

openshift-ci · 2026-06-17T07:27:27Z

New changes are detected. LGTM label has been removed.

kyoto added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2026

openshift-ci Bot requested review from JoaoFula and syedriko June 16, 2026 05:55

coderabbitai Bot reviewed Jun 16, 2026

View reviewed changes

4.19: Tests: Fix goToPodDetails helper flakiness

f3a1f61

kyoto force-pushed the 4.19-fix-goToPodDetails branch from edf87fa to f3a1f61 Compare June 17, 2026 07:27

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

4.19: Tests: Fix goToPodDetails helper flakiness#2081

4.19: Tests: Fix goToPodDetails helper flakiness#2081
kyoto wants to merge 1 commit into
openshift:release-4.19from
kyoto:4.19-fix-goToPodDetails

kyoto commented Jun 16, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 16, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

openshift-ci Bot commented Jun 16, 2026

Uh oh!

openshift-ci Bot commented Jun 16, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Jun 16, 2026

Uh oh!

kyoto commented Jun 16, 2026

Uh oh!

openshift-ci Bot commented Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

-  const link = page.locator(resourceRows).filter({ hasText: podName });
-  await expect(link.first()).toBeVisible({ timeout: 30_000 });
-  await link.first().click();
+  const row = page.locator(resourceRows).filter({ hasText: podName }).first();
+  const link = row.locator('a.co-resource-item__resource-name').first();
+  await expect(link).toBeVisible({ timeout: 30_000 });
+  await link.click();

Conversation

kyoto commented Jun 16, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

openshift-ci Bot commented Jun 16, 2026

Uh oh!

openshift-ci Bot commented Jun 16, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

kyoto commented Jun 16, 2026

Uh oh!

openshift-ci Bot commented Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kyoto commented Jun 16, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 16, 2026 •

edited

Loading