OLS-2987: Define agentic telemetry data model#146
Conversation
|
@blublinsky: This pull request references OLS-2987 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughSummary by CodeRabbit
WalkthroughA new spec file ChangesAgentic Telemetry Data Model Spec
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.ai/spec/what/telemetry.md (1)
245-245: ⚡ Quick winClarify the analytics question with concrete product intent.
The phrasing "make the system better" is vague. Specify what analytics outcomes or KPIs you're targeting (e.g., reliability metrics, cost optimization, bottleneck identification, etc.).
💡 Suggested revision
-1. Which Proposal Summary fields does product actually need for "make the system better" analytics? +1. Which Proposal Summary fields does product actually need for analytics on system reliability, cost, and performance optimization?Or a more generic version:
-1. Which Proposal Summary fields does product actually need for "make the system better" analytics? +1. Which Proposal Summary fields does product actually need to improve observability and inform system optimizations?🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.ai/spec/what/telemetry.md at line 245, Replace the vague phrase "make the system better" in the question at the specified location with concrete, measurable analytics outcomes and KPIs. Specify what product actually intends to measure or optimize for, such as reliability metrics, cost optimization, bottleneck identification, performance analysis, or other specific product objectives. This clarification will help define which Proposal Summary fields are truly needed for the analytics goals.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.ai/spec/what/telemetry.md:
- Line 245: Replace the vague phrase "make the system better" in the question at
the specified location with concrete, measurable analytics outcomes and KPIs.
Specify what product actually intends to measure or optimize for, such as
reliability metrics, cost optimization, bottleneck identification, performance
analysis, or other specific product objectives. This clarification will help
define which Proposal Summary fields are truly needed for the analytics goals.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 5d401695-728e-4ee5-9b3d-bfee00a9a307
📒 Files selected for processing (1)
.ai/spec/what/telemetry.md
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
openshift/lightspeed-agentic-sandbox(manual)
Summary
Delivers the schema definition document for the agentic telemetry data model. Defines four tiers of telemetry (step metrics, proposal summary, transcript, audit trail), data classification, and extensibility principles.
Key design decisions
Nested structure: Proposal summary contains steps[] array with per-step metrics derived from Result CRs
Tiers are independent: Each tier works without the others; no breaking changes when adding higher tiers
Transcript is agent-owned: The operator does not collect prompt/tool data — the agent logs it
Audit trail extends Proposal Summary: Not a separate record — adds identity/authorization columns
Sensitivity gates export: Non-sensitive ships by default; medium requires opt-in; high requires explicit configuration
finalPhase instead of "outcome" — maps directly to operator's DerivePhase() terminology
Open questions (requiring BU input)
Which Proposal Summary fields does the product need for analytics?
Dataverse table structure — reuse OLS transcript schema or new?
Export cadence — real-time or batch?
Retention policy?
Which compliance regulations apply?