Skip to content

Drop estimatedImpact from AgentProposal type#45

Open
harche wants to merge 1 commit into
mainfrom
drop-estimated-impact
Open

Drop estimatedImpact from AgentProposal type#45
harche wants to merge 1 commit into
mainfrom
drop-estimated-impact

Conversation

@harche

@harche harche commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Console-side companion to openshift/lightspeed-agentic-operator#162 / its PR #174.

Change

Remove the optional estimatedImpact?: string member from the AgentProposal type in src/models/proposal.ts, matching the operator dropping the field from the AnalysisResult CRD.

Notes

  • The field was never rendered in the UI (no component reads it; ProposalDetailPage shows risk/reversible/rollbackPlan only), so this is a pure type cleanup with no UI impact.
  • These types are hand-maintained (there's a TODO to auto-generate from the CRD OpenAPI schema), so this keeps them in sync manually.
  • proposal.ts lints clean; npm run build succeeds.

🤖 Generated with Claude Code

Mirror the operator-side removal of estimatedImpact
(openshift/lightspeed-agentic-operator#162). The field was an optional
member of the AgentProposal type and was never rendered in the console UI.
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2026
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@harche, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 51 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4104788e-d993-4bcb-8558-71f54feed49c

📥 Commits

Reviewing files that changed from the base of the PR and between 33f59ff and a64cf55.

📒 Files selected for processing (1)
  • src/models/proposal.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xrajesh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harche harche changed the title WIP: Drop estimatedImpact from AgentProposal type Drop estimatedImpact from AgentProposal type Jun 19, 2026
@harche harche marked this pull request as ready for review June 19, 2026 14:55
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2026
@openshift-ci openshift-ci Bot requested review from joshuawilson and xrajesh June 19, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant