Skip to content

HIVE-3134: Use native golang DNS capabilities instead of pulling in a library#2887

Open
dlom wants to merge 1 commit intoopenshift:masterfrom
dlom:HIVE-3134-remove-dns-lib
Open

HIVE-3134: Use native golang DNS capabilities instead of pulling in a library#2887
dlom wants to merge 1 commit intoopenshift:masterfrom
dlom:HIVE-3134-remove-dns-lib

Conversation

@dlom
Copy link
Copy Markdown
Contributor

@dlom dlom commented Mar 27, 2026

xref: HIVE-3134

Instead of pulling in an entire 30k line library just to check if a DNS record exists, we can use the go standard library. Both SOA and NS records are mandatory for any valid DNS zone, so we can check for NS records instead of SOA records. All we're checking is "is this zone reachable?" and the NS record will still tell us that

/assign @2uasimojo

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 27, 2026

@dlom: This pull request references HIVE-3134 which is a valid jira issue.

Details

In response to this:

xref: HIVE-3134

Instead of pulling in an entire 30k line library just to check if a DNS record exists, we can use the go standard library. Both SOA and NS records are mandatory for any valid DNS zone, so we can check for NS records instead of SOA records. All we're checking is "is this zone reachable?" and the NS record will still tell us that

/assign @2uasimojo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026

Important

Review skipped

Too many files!

This PR contains 299 files, which is 149 over the limit of 150.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c7e52c79-ac47-4362-b9a7-6b8cec1a50f9

📥 Commits

Reviewing files that changed from the base of the PR and between 2297bc8 and 6c4ec18.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (299)
  • go.mod
  • pkg/controller/dnszone/dnszone_controller.go
  • pkg/controller/dnszone/dnszone_controller_test.go
  • vendor/github.com/miekg/dns/.codecov.yml
  • vendor/github.com/miekg/dns/.gitignore
  • vendor/github.com/miekg/dns/.travis.yml
  • vendor/github.com/miekg/dns/AUTHORS
  • vendor/github.com/miekg/dns/CODEOWNERS
  • vendor/github.com/miekg/dns/CONTRIBUTORS
  • vendor/github.com/miekg/dns/COPYRIGHT
  • vendor/github.com/miekg/dns/LICENSE
  • vendor/github.com/miekg/dns/Makefile.fuzz
  • vendor/github.com/miekg/dns/Makefile.release
  • vendor/github.com/miekg/dns/README.md
  • vendor/github.com/miekg/dns/acceptfunc.go
  • vendor/github.com/miekg/dns/client.go
  • vendor/github.com/miekg/dns/clientconfig.go
  • vendor/github.com/miekg/dns/dane.go
  • vendor/github.com/miekg/dns/defaults.go
  • vendor/github.com/miekg/dns/dns.go
  • vendor/github.com/miekg/dns/dnssec.go
  • vendor/github.com/miekg/dns/dnssec_keygen.go
  • vendor/github.com/miekg/dns/dnssec_keyscan.go
  • vendor/github.com/miekg/dns/dnssec_privkey.go
  • vendor/github.com/miekg/dns/doc.go
  • vendor/github.com/miekg/dns/duplicate.go
  • vendor/github.com/miekg/dns/edns.go
  • vendor/github.com/miekg/dns/format.go
  • vendor/github.com/miekg/dns/fuzz.go
  • vendor/github.com/miekg/dns/generate.go
  • vendor/github.com/miekg/dns/labels.go
  • vendor/github.com/miekg/dns/listen_go111.go
  • vendor/github.com/miekg/dns/listen_go_not111.go
  • vendor/github.com/miekg/dns/msg.go
  • vendor/github.com/miekg/dns/msg_helpers.go
  • vendor/github.com/miekg/dns/msg_truncate.go
  • vendor/github.com/miekg/dns/nsecx.go
  • vendor/github.com/miekg/dns/privaterr.go
  • vendor/github.com/miekg/dns/reverse.go
  • vendor/github.com/miekg/dns/sanitize.go
  • vendor/github.com/miekg/dns/scan.go
  • vendor/github.com/miekg/dns/scan_rr.go
  • vendor/github.com/miekg/dns/serve_mux.go
  • vendor/github.com/miekg/dns/server.go
  • vendor/github.com/miekg/dns/sig0.go
  • vendor/github.com/miekg/dns/singleinflight.go
  • vendor/github.com/miekg/dns/smimea.go
  • vendor/github.com/miekg/dns/svcb.go
  • vendor/github.com/miekg/dns/tlsa.go
  • vendor/github.com/miekg/dns/tsig.go
  • vendor/github.com/miekg/dns/types.go
  • vendor/github.com/miekg/dns/udp.go
  • vendor/github.com/miekg/dns/udp_windows.go
  • vendor/github.com/miekg/dns/update.go
  • vendor/github.com/miekg/dns/version.go
  • vendor/github.com/miekg/dns/xfr.go
  • vendor/github.com/miekg/dns/zduplicate.go
  • vendor/github.com/miekg/dns/zmsg.go
  • vendor/github.com/miekg/dns/ztypes.go
  • vendor/golang.org/x/crypto/ed25519/ed25519.go
  • vendor/golang.org/x/net/bpf/asm.go
  • vendor/golang.org/x/net/bpf/constants.go
  • vendor/golang.org/x/net/bpf/doc.go
  • vendor/golang.org/x/net/bpf/instructions.go
  • vendor/golang.org/x/net/bpf/setter.go
  • vendor/golang.org/x/net/bpf/vm.go
  • vendor/golang.org/x/net/bpf/vm_instructions.go
  • vendor/golang.org/x/net/internal/iana/const.go
  • vendor/golang.org/x/net/internal/socket/cmsghdr.go
  • vendor/golang.org/x/net/internal/socket/cmsghdr_bsd.go
  • vendor/golang.org/x/net/internal/socket/cmsghdr_linux_32bit.go
  • vendor/golang.org/x/net/internal/socket/cmsghdr_linux_64bit.go
  • vendor/golang.org/x/net/internal/socket/cmsghdr_solaris_64bit.go
  • vendor/golang.org/x/net/internal/socket/cmsghdr_stub.go
  • vendor/golang.org/x/net/internal/socket/cmsghdr_unix.go
  • vendor/golang.org/x/net/internal/socket/cmsghdr_zos_s390x.go
  • vendor/golang.org/x/net/internal/socket/complete_dontwait.go
  • vendor/golang.org/x/net/internal/socket/complete_nodontwait.go
  • vendor/golang.org/x/net/internal/socket/empty.s
  • vendor/golang.org/x/net/internal/socket/error_unix.go
  • vendor/golang.org/x/net/internal/socket/error_windows.go
  • vendor/golang.org/x/net/internal/socket/iovec_32bit.go
  • vendor/golang.org/x/net/internal/socket/iovec_64bit.go
  • vendor/golang.org/x/net/internal/socket/iovec_solaris_64bit.go
  • vendor/golang.org/x/net/internal/socket/iovec_stub.go
  • vendor/golang.org/x/net/internal/socket/mmsghdr_stub.go
  • vendor/golang.org/x/net/internal/socket/mmsghdr_unix.go
  • vendor/golang.org/x/net/internal/socket/msghdr_bsd.go
  • vendor/golang.org/x/net/internal/socket/msghdr_bsdvar.go
  • vendor/golang.org/x/net/internal/socket/msghdr_linux.go
  • vendor/golang.org/x/net/internal/socket/msghdr_linux_32bit.go
  • vendor/golang.org/x/net/internal/socket/msghdr_linux_64bit.go
  • vendor/golang.org/x/net/internal/socket/msghdr_openbsd.go
  • vendor/golang.org/x/net/internal/socket/msghdr_solaris_64bit.go
  • vendor/golang.org/x/net/internal/socket/msghdr_stub.go
  • vendor/golang.org/x/net/internal/socket/msghdr_zos_s390x.go
  • vendor/golang.org/x/net/internal/socket/norace.go
  • vendor/golang.org/x/net/internal/socket/race.go
  • vendor/golang.org/x/net/internal/socket/rawconn.go
  • vendor/golang.org/x/net/internal/socket/rawconn_mmsg.go
  • vendor/golang.org/x/net/internal/socket/rawconn_msg.go
  • vendor/golang.org/x/net/internal/socket/rawconn_nommsg.go
  • vendor/golang.org/x/net/internal/socket/rawconn_nomsg.go
  • vendor/golang.org/x/net/internal/socket/socket.go
  • vendor/golang.org/x/net/internal/socket/sys.go
  • vendor/golang.org/x/net/internal/socket/sys_bsd.go
  • vendor/golang.org/x/net/internal/socket/sys_const_unix.go
  • vendor/golang.org/x/net/internal/socket/sys_linux.go
  • vendor/golang.org/x/net/internal/socket/sys_linux_386.go
  • vendor/golang.org/x/net/internal/socket/sys_linux_386.s
  • vendor/golang.org/x/net/internal/socket/sys_linux_amd64.go
  • vendor/golang.org/x/net/internal/socket/sys_linux_arm.go
  • vendor/golang.org/x/net/internal/socket/sys_linux_arm64.go
  • vendor/golang.org/x/net/internal/socket/sys_linux_loong64.go
  • vendor/golang.org/x/net/internal/socket/sys_linux_mips.go
  • vendor/golang.org/x/net/internal/socket/sys_linux_mips64.go
  • vendor/golang.org/x/net/internal/socket/sys_linux_mips64le.go
  • vendor/golang.org/x/net/internal/socket/sys_linux_mipsle.go
  • vendor/golang.org/x/net/internal/socket/sys_linux_ppc.go
  • vendor/golang.org/x/net/internal/socket/sys_linux_ppc64.go
  • vendor/golang.org/x/net/internal/socket/sys_linux_ppc64le.go
  • vendor/golang.org/x/net/internal/socket/sys_linux_riscv64.go
  • vendor/golang.org/x/net/internal/socket/sys_linux_s390x.go
  • vendor/golang.org/x/net/internal/socket/sys_linux_s390x.s
  • vendor/golang.org/x/net/internal/socket/sys_netbsd.go
  • vendor/golang.org/x/net/internal/socket/sys_posix.go
  • vendor/golang.org/x/net/internal/socket/sys_stub.go
  • vendor/golang.org/x/net/internal/socket/sys_unix.go
  • vendor/golang.org/x/net/internal/socket/sys_windows.go
  • vendor/golang.org/x/net/internal/socket/sys_zos_s390x.go
  • vendor/golang.org/x/net/internal/socket/sys_zos_s390x.s
  • vendor/golang.org/x/net/internal/socket/zsys_aix_ppc64.go
  • vendor/golang.org/x/net/internal/socket/zsys_darwin_amd64.go
  • vendor/golang.org/x/net/internal/socket/zsys_darwin_arm64.go
  • vendor/golang.org/x/net/internal/socket/zsys_dragonfly_amd64.go
  • vendor/golang.org/x/net/internal/socket/zsys_freebsd_386.go
  • vendor/golang.org/x/net/internal/socket/zsys_freebsd_amd64.go
  • vendor/golang.org/x/net/internal/socket/zsys_freebsd_arm.go
  • vendor/golang.org/x/net/internal/socket/zsys_freebsd_arm64.go
  • vendor/golang.org/x/net/internal/socket/zsys_freebsd_riscv64.go
  • vendor/golang.org/x/net/internal/socket/zsys_linux_386.go
  • vendor/golang.org/x/net/internal/socket/zsys_linux_amd64.go
  • vendor/golang.org/x/net/internal/socket/zsys_linux_arm.go
  • vendor/golang.org/x/net/internal/socket/zsys_linux_arm64.go
  • vendor/golang.org/x/net/internal/socket/zsys_linux_loong64.go
  • vendor/golang.org/x/net/internal/socket/zsys_linux_mips.go
  • vendor/golang.org/x/net/internal/socket/zsys_linux_mips64.go
  • vendor/golang.org/x/net/internal/socket/zsys_linux_mips64le.go
  • vendor/golang.org/x/net/internal/socket/zsys_linux_mipsle.go
  • vendor/golang.org/x/net/internal/socket/zsys_linux_ppc.go
  • vendor/golang.org/x/net/internal/socket/zsys_linux_ppc64.go
  • vendor/golang.org/x/net/internal/socket/zsys_linux_ppc64le.go
  • vendor/golang.org/x/net/internal/socket/zsys_linux_riscv64.go
  • vendor/golang.org/x/net/internal/socket/zsys_linux_s390x.go
  • vendor/golang.org/x/net/internal/socket/zsys_netbsd_386.go
  • vendor/golang.org/x/net/internal/socket/zsys_netbsd_amd64.go
  • vendor/golang.org/x/net/internal/socket/zsys_netbsd_arm.go
  • vendor/golang.org/x/net/internal/socket/zsys_netbsd_arm64.go
  • vendor/golang.org/x/net/internal/socket/zsys_openbsd_386.go
  • vendor/golang.org/x/net/internal/socket/zsys_openbsd_amd64.go
  • vendor/golang.org/x/net/internal/socket/zsys_openbsd_arm.go
  • vendor/golang.org/x/net/internal/socket/zsys_openbsd_arm64.go
  • vendor/golang.org/x/net/internal/socket/zsys_openbsd_mips64.go
  • vendor/golang.org/x/net/internal/socket/zsys_openbsd_ppc64.go
  • vendor/golang.org/x/net/internal/socket/zsys_openbsd_riscv64.go
  • vendor/golang.org/x/net/internal/socket/zsys_solaris_amd64.go
  • vendor/golang.org/x/net/internal/socket/zsys_zos_s390x.go
  • vendor/golang.org/x/net/ipv4/batch.go
  • vendor/golang.org/x/net/ipv4/control.go
  • vendor/golang.org/x/net/ipv4/control_bsd.go
  • vendor/golang.org/x/net/ipv4/control_pktinfo.go
  • vendor/golang.org/x/net/ipv4/control_stub.go
  • vendor/golang.org/x/net/ipv4/control_unix.go
  • vendor/golang.org/x/net/ipv4/control_windows.go
  • vendor/golang.org/x/net/ipv4/control_zos.go
  • vendor/golang.org/x/net/ipv4/dgramopt.go
  • vendor/golang.org/x/net/ipv4/doc.go
  • vendor/golang.org/x/net/ipv4/endpoint.go
  • vendor/golang.org/x/net/ipv4/genericopt.go
  • vendor/golang.org/x/net/ipv4/header.go
  • vendor/golang.org/x/net/ipv4/helper.go
  • vendor/golang.org/x/net/ipv4/iana.go
  • vendor/golang.org/x/net/ipv4/icmp.go
  • vendor/golang.org/x/net/ipv4/icmp_linux.go
  • vendor/golang.org/x/net/ipv4/icmp_stub.go
  • vendor/golang.org/x/net/ipv4/packet.go
  • vendor/golang.org/x/net/ipv4/payload.go
  • vendor/golang.org/x/net/ipv4/payload_cmsg.go
  • vendor/golang.org/x/net/ipv4/payload_nocmsg.go
  • vendor/golang.org/x/net/ipv4/sockopt.go
  • vendor/golang.org/x/net/ipv4/sockopt_posix.go
  • vendor/golang.org/x/net/ipv4/sockopt_stub.go
  • vendor/golang.org/x/net/ipv4/sys_aix.go
  • vendor/golang.org/x/net/ipv4/sys_asmreq.go
  • vendor/golang.org/x/net/ipv4/sys_asmreq_stub.go
  • vendor/golang.org/x/net/ipv4/sys_asmreqn.go
  • vendor/golang.org/x/net/ipv4/sys_asmreqn_stub.go
  • vendor/golang.org/x/net/ipv4/sys_bpf.go
  • vendor/golang.org/x/net/ipv4/sys_bpf_stub.go
  • vendor/golang.org/x/net/ipv4/sys_bsd.go
  • vendor/golang.org/x/net/ipv4/sys_darwin.go
  • vendor/golang.org/x/net/ipv4/sys_dragonfly.go
  • vendor/golang.org/x/net/ipv4/sys_freebsd.go
  • vendor/golang.org/x/net/ipv4/sys_linux.go
  • vendor/golang.org/x/net/ipv4/sys_solaris.go
  • vendor/golang.org/x/net/ipv4/sys_ssmreq.go
  • vendor/golang.org/x/net/ipv4/sys_ssmreq_stub.go
  • vendor/golang.org/x/net/ipv4/sys_stub.go
  • vendor/golang.org/x/net/ipv4/sys_windows.go
  • vendor/golang.org/x/net/ipv4/sys_zos.go
  • vendor/golang.org/x/net/ipv4/zsys_aix_ppc64.go
  • vendor/golang.org/x/net/ipv4/zsys_darwin.go
  • vendor/golang.org/x/net/ipv4/zsys_dragonfly.go
  • vendor/golang.org/x/net/ipv4/zsys_freebsd_386.go
  • vendor/golang.org/x/net/ipv4/zsys_freebsd_amd64.go
  • vendor/golang.org/x/net/ipv4/zsys_freebsd_arm.go
  • vendor/golang.org/x/net/ipv4/zsys_freebsd_arm64.go
  • vendor/golang.org/x/net/ipv4/zsys_freebsd_riscv64.go
  • vendor/golang.org/x/net/ipv4/zsys_linux_386.go
  • vendor/golang.org/x/net/ipv4/zsys_linux_amd64.go
  • vendor/golang.org/x/net/ipv4/zsys_linux_arm.go
  • vendor/golang.org/x/net/ipv4/zsys_linux_arm64.go
  • vendor/golang.org/x/net/ipv4/zsys_linux_loong64.go
  • vendor/golang.org/x/net/ipv4/zsys_linux_mips.go
  • vendor/golang.org/x/net/ipv4/zsys_linux_mips64.go
  • vendor/golang.org/x/net/ipv4/zsys_linux_mips64le.go
  • vendor/golang.org/x/net/ipv4/zsys_linux_mipsle.go
  • vendor/golang.org/x/net/ipv4/zsys_linux_ppc.go
  • vendor/golang.org/x/net/ipv4/zsys_linux_ppc64.go
  • vendor/golang.org/x/net/ipv4/zsys_linux_ppc64le.go
  • vendor/golang.org/x/net/ipv4/zsys_linux_riscv64.go
  • vendor/golang.org/x/net/ipv4/zsys_linux_s390x.go
  • vendor/golang.org/x/net/ipv4/zsys_netbsd.go
  • vendor/golang.org/x/net/ipv4/zsys_openbsd.go
  • vendor/golang.org/x/net/ipv4/zsys_solaris.go
  • vendor/golang.org/x/net/ipv4/zsys_zos_s390x.go
  • vendor/golang.org/x/net/ipv6/batch.go
  • vendor/golang.org/x/net/ipv6/control.go
  • vendor/golang.org/x/net/ipv6/control_rfc2292_unix.go
  • vendor/golang.org/x/net/ipv6/control_rfc3542_unix.go
  • vendor/golang.org/x/net/ipv6/control_stub.go
  • vendor/golang.org/x/net/ipv6/control_unix.go
  • vendor/golang.org/x/net/ipv6/control_windows.go
  • vendor/golang.org/x/net/ipv6/dgramopt.go
  • vendor/golang.org/x/net/ipv6/doc.go
  • vendor/golang.org/x/net/ipv6/endpoint.go
  • vendor/golang.org/x/net/ipv6/genericopt.go
  • vendor/golang.org/x/net/ipv6/header.go
  • vendor/golang.org/x/net/ipv6/helper.go
  • vendor/golang.org/x/net/ipv6/iana.go
  • vendor/golang.org/x/net/ipv6/icmp.go
  • vendor/golang.org/x/net/ipv6/icmp_bsd.go
  • vendor/golang.org/x/net/ipv6/icmp_linux.go
  • vendor/golang.org/x/net/ipv6/icmp_solaris.go
  • vendor/golang.org/x/net/ipv6/icmp_stub.go
  • vendor/golang.org/x/net/ipv6/icmp_windows.go
  • vendor/golang.org/x/net/ipv6/icmp_zos.go
  • vendor/golang.org/x/net/ipv6/payload.go
  • vendor/golang.org/x/net/ipv6/payload_cmsg.go
  • vendor/golang.org/x/net/ipv6/payload_nocmsg.go
  • vendor/golang.org/x/net/ipv6/sockopt.go
  • vendor/golang.org/x/net/ipv6/sockopt_posix.go
  • vendor/golang.org/x/net/ipv6/sockopt_stub.go
  • vendor/golang.org/x/net/ipv6/sys_aix.go
  • vendor/golang.org/x/net/ipv6/sys_asmreq.go
  • vendor/golang.org/x/net/ipv6/sys_asmreq_stub.go
  • vendor/golang.org/x/net/ipv6/sys_bpf.go
  • vendor/golang.org/x/net/ipv6/sys_bpf_stub.go
  • vendor/golang.org/x/net/ipv6/sys_bsd.go
  • vendor/golang.org/x/net/ipv6/sys_darwin.go
  • vendor/golang.org/x/net/ipv6/sys_freebsd.go
  • vendor/golang.org/x/net/ipv6/sys_linux.go
  • vendor/golang.org/x/net/ipv6/sys_solaris.go
  • vendor/golang.org/x/net/ipv6/sys_ssmreq.go
  • vendor/golang.org/x/net/ipv6/sys_ssmreq_stub.go
  • vendor/golang.org/x/net/ipv6/sys_stub.go
  • vendor/golang.org/x/net/ipv6/sys_windows.go
  • vendor/golang.org/x/net/ipv6/sys_zos.go
  • vendor/golang.org/x/net/ipv6/zsys_aix_ppc64.go
  • vendor/golang.org/x/net/ipv6/zsys_darwin.go
  • vendor/golang.org/x/net/ipv6/zsys_dragonfly.go
  • vendor/golang.org/x/net/ipv6/zsys_freebsd_386.go
  • vendor/golang.org/x/net/ipv6/zsys_freebsd_amd64.go
  • vendor/golang.org/x/net/ipv6/zsys_freebsd_arm.go
  • vendor/golang.org/x/net/ipv6/zsys_freebsd_arm64.go
  • vendor/golang.org/x/net/ipv6/zsys_freebsd_riscv64.go
  • vendor/golang.org/x/net/ipv6/zsys_linux_386.go
  • vendor/golang.org/x/net/ipv6/zsys_linux_amd64.go
  • vendor/golang.org/x/net/ipv6/zsys_linux_arm.go
  • vendor/golang.org/x/net/ipv6/zsys_linux_arm64.go
  • vendor/golang.org/x/net/ipv6/zsys_linux_loong64.go
  • vendor/golang.org/x/net/ipv6/zsys_linux_mips.go
  • vendor/golang.org/x/net/ipv6/zsys_linux_mips64.go
  • vendor/golang.org/x/net/ipv6/zsys_linux_mips64le.go
  • vendor/golang.org/x/net/ipv6/zsys_linux_mipsle.go
  • vendor/golang.org/x/net/ipv6/zsys_linux_ppc.go
  • vendor/golang.org/x/net/ipv6/zsys_linux_ppc64.go
  • vendor/golang.org/x/net/ipv6/zsys_linux_ppc64le.go
  • vendor/golang.org/x/net/ipv6/zsys_linux_riscv64.go

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 27, 2026

@dlom: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 21.62162% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.29%. Comparing base (958db34) to head (6c4ec18).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/controller/dnszone/dnszone_controller.go 21.62% 29 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2887      +/-   ##
==========================================
- Coverage   50.29%   50.29%   -0.01%     
==========================================
  Files         280      280              
  Lines       34323    34328       +5     
==========================================
  Hits        17264    17264              
- Misses      15698    15703       +5     
  Partials     1361     1361              
Files with missing lines Coverage Δ
pkg/controller/dnszone/dnszone_controller.go 29.24% <21.62%> (+0.36%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants