HIVE-3134: Use native golang DNS capabilities instead of pulling in a library#2887
HIVE-3134: Use native golang DNS capabilities instead of pulling in a library#2887dlom wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
@dlom: This pull request references HIVE-3134 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedToo many files! This PR contains 299 files, which is 149 over the limit of 150. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (299)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@dlom: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2887 +/- ##
==========================================
- Coverage 50.29% 50.29% -0.01%
==========================================
Files 280 280
Lines 34323 34328 +5
==========================================
Hits 17264 17264
- Misses 15698 15703 +5
Partials 1361 1361
🚀 New features to boost your workflow:
|
xref: HIVE-3134
Instead of pulling in an entire 30k line library just to check if a DNS record exists, we can use the go standard library. Both SOA and NS records are mandatory for any valid DNS zone, so we can check for NS records instead of SOA records. All we're checking is "is this zone reachable?" and the NS record will still tell us that
/assign @2uasimojo