Skip to content

NO-JIRA: Clarify the secretref datakey structure reason#2009

Open
ardaguclu wants to merge 1 commit into
openshift:masterfrom
ardaguclu:clarify-kms-secretref
Open

NO-JIRA: Clarify the secretref datakey structure reason#2009
ardaguclu wants to merge 1 commit into
openshift:masterfrom
ardaguclu:clarify-kms-secretref

Conversation

@ardaguclu
Copy link
Copy Markdown
Member

@ardaguclu ardaguclu commented May 14, 2026

We decided to store the SecretRef content as separate data keys in the key Secret and the encryption-config Secret, rather than using a single structured data key for each keyID.

This PR documents the rationale in the EP. So I stop forgetting it and suggesting the nested structure idea over and over again.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 14, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@ardaguclu: This pull request explicitly references no jira issue.

Details

In response to this:

We decided to carry the content of SecretRef as a separate datakey field in key Secret and encryption-config Secret instead of one structured data key per each keyID.

This PR clarifies the reason in the EP. So that I don't forget every time and propose nested structure idea every day.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from jupierce and moadz May 14, 2026 11:01
@ardaguclu
Copy link
Copy Markdown
Member Author

/cc @p0lyn0mial @bertinatto

@openshift-ci openshift-ci Bot requested review from bertinatto and p0lyn0mial May 14, 2026 11:05
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@benluddy
Copy link
Copy Markdown

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants