Skip to content

Add adversarial review skill for enhancement proposals#1980

Open
jhjaggars wants to merge 1 commit into
masterfrom
jjaggars/add-review-enhancement-skill
Open

Add adversarial review skill for enhancement proposals#1980
jhjaggars wants to merge 1 commit into
masterfrom
jjaggars/add-review-enhancement-skill

Conversation

@jhjaggars
Copy link
Copy Markdown

@jhjaggars jhjaggars commented Apr 22, 2026

  • Adds a Claude Code slash command (.claude/commands/review-enhancement.md) that performs structured, multi-lens adversarial review of OpenShift Enhancement Proposals
  • Spawns 4 parallel review agents covering API design, systems safety, architecture/platform scope, and code verification
  • Review criteria modeled on analysis of ~40,000 review comments across 586 merged PRs in this repo
  • Run /review-enhancement against a draft EP and verify all 4 agents spawn and return findings
  • Run with repos argument to verify code verification agent activates
  • Confirm output follows the structured format (Blocking / Code-Grounded / Significant / Nits / What's Good / Reviewer Simulations)
    🤖 Generated with Claude Code

@jhjaggars
Add adversarial review skill for enhancement proposals
306e0ff 
Introduces a Claude Code slash command that spawns parallel review agents
to perform structured, multi-lens adversarial review of OpenShift
Enhancement Proposals, modeled on the most prolific reviewers in this repo.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci openshift-ci Bot requested review from jmguzik and sdodson April 22, 2026 16:14
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 22, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign miciah for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 22, 2026

@jhjaggars: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

mkowalski added a commit to mkowalski/openshift-enhancements that referenced this pull request Apr 23, 2026
@mkowalski
OPNET-773: address review findings from PR openshift#1980
0dbf9dc 
Address findings from adversarial enhancement review per
https://github.com/openshift/enhancements/pull/1980/changes

Closes: https://redhat.atlassian.net/browse/OPNET-773
Epic: https://redhat.atlassian.net/browse/OPNET-595
@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented May 15, 2026

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmguzik jmguzik Awaiting requested review from jmguzik

@sdodson sdodson Awaiting requested review from sdodson

Assignees

@JoelSpeed JoelSpeed

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jhjaggars @JoelSpeed