NO-JIRA: Normalize generation of driver metrics RBAC proxy sidecar (extended)

[stephenfin]

This builds on #380 by changing the name of the proxy sidecar used for driver metrics.

[openshift-ci-robot]

@stephenfin: This pull request explicitly references no jira issue.

Details

In response to this:

This builds on #380 by changing the name of the proxy sidecar used for driver metrics.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [stephenfin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stephenfin]

/retest

[stephenfin]

/retest

[stephenfin]

/test e2e-openstack

[stephenfin]

/test e2e-openstack

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[dobsonj]

/lgtm

[duanwei33]

/retest

[duanwei33]

/unassign @Phaow @chao007 @radeore

[duanwei33]

/retest

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[stephenfin]

/remove-lifecycle rotten

[stephenfin]

I've just rebased this on top of master, to catch any changes that might affect this. This is otherwise identical to previously. Hopefully CI is happier now 🤞

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1b91f8fd-9919-4ce1-af18-588736cd077e

📥 Commits

Reviewing files that changed from the base of the PR and between b38105b and 4a16bcc.

⛔ Files ignored due to path filters (11)

• assets/overlays/aws-ebs/generated/hypershift/controller.yaml is excluded by !**/generated/**
• assets/overlays/aws-ebs/generated/standalone/controller.yaml is excluded by !**/generated/**
• assets/overlays/azure-disk/generated/hypershift/controller.yaml is excluded by !**/generated/**
• assets/overlays/azure-disk/generated/hypershift/node.yaml is excluded by !**/generated/**
• assets/overlays/azure-disk/generated/standalone/controller.yaml is excluded by !**/generated/**
• assets/overlays/azure-disk/generated/standalone/node.yaml is excluded by !**/generated/**
• assets/overlays/azure-file/generated/hypershift/controller.yaml is excluded by !**/generated/**
• assets/overlays/azure-file/generated/standalone/controller.yaml is excluded by !**/generated/**
• assets/overlays/openstack-cinder/generated/hypershift/controller.yaml is excluded by !**/generated/**
• assets/overlays/openstack-cinder/generated/standalone/controller.yaml is excluded by !**/generated/**
• assets/overlays/samba/generated/standalone/controller.yaml is excluded by !**/generated/**

📒 Files selected for processing (4)

• assets/common/sidecars/controller_driver_kube_rbac_proxy.yaml
• assets/common/sidecars/node_driver_kube_rbac_proxy.yaml
• pkg/driver/common/operator/hooks_test.go
• pkg/driver/common/operator/test_manifests/aws_ebs_controller_hypershift.yaml

✅ Files skipped from review due to trivial changes (2)

• assets/common/sidecars/controller_driver_kube_rbac_proxy.yaml
• assets/common/sidecars/node_driver_kube_rbac_proxy.yaml

🚧 Files skipped from review as they are similar to previous changes (2)

• pkg/driver/common/operator/test_manifests/aws_ebs_controller_hypershift.yaml
• pkg/driver/common/operator/hooks_test.go

---

📝 Walkthrough

Walkthrough

The kube-rbac-proxy sidecar container name was changed to driver-kube-rbac-proxy in two asset sidecar manifests and an AWS EBS controller hypershift test manifest. A unit test expectation in pkg/driver/common/operator/hooks_test.go was updated to reference driver-kube-rbac-proxy (image assertion unchanged). No other container fields or specifications were modified.

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: normalizing the driver metrics RBAC proxy sidecar container name from a port-templated value to a fixed identifier across multiple files.
Description check	✅ Passed	The description is related to the changeset, explaining that it builds on PR #380 by changing the proxy sidecar name used for driver metrics, which matches the actual changes shown.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All test names in the modified test file (hooks_test.go) are static, deterministic strings with no dynamic content like UUIDs, timestamps, pod names, or other values that change between runs.
Test Structure And Quality	✅ Passed	The custom check is for Ginkgo test code, but this PR uses standard Go testing package (testing.T, t.Run, t.Errorf). The check is not applicable to this PR.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests are being added. Only an existing traditional Go unit test is modified to update expected container names after a rename.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. It only modifies YAML manifests and existing Go unit tests. The SNO compatibility check only applies to new Ginkgo e2e tests.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only updates container names in sidecars and tests. No scheduling constraints, affinity rules, or topology assumptions are introduced.
Ote Binary Stdout Contract	✅ Passed	The PR modifies only YAML manifests and test assertions. No process-level code writing to stdout is changed. OTE Stdout Contract not violated.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests added. Repository doesn't use Ginkgo. Changes are YAML manifests and existing Go unit test modifications only.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jsafrane]

/retest-required
/lgtm

[openshift-ci]

@stephenfin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-file-nfs-csi-hypershift	4a16bcc	link	false	/test e2e-azure-file-nfs-csi-hypershift
ci/prow/smb-win2022-operator-e2e	4a16bcc	link	false	/test smb-win2022-operator-e2e
ci/prow/e2e-azure-file-csi-hypershift	4a16bcc	link	false	/test e2e-azure-file-csi-hypershift
ci/prow/e2e-openstack	4a16bcc	link	false	/test e2e-openstack
ci/prow/hypershift-e2e-openstack-aws-csi-cinder	4a16bcc	link	true	/test hypershift-e2e-openstack-aws-csi-cinder
ci/prow/smb-win2019-operator-e2e	4a16bcc	link	false	/test smb-win2019-operator-e2e
ci/prow/smb-operator-e2e-extended	4a16bcc	link	false	/test smb-operator-e2e-extended
ci/prow/e2e-azure-csi-hypershift	4a16bcc	link	false	/test e2e-azure-csi-hypershift
ci/prow/e2e-azurestack-csi	4a16bcc	link	false	/test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.