Skip to content

[DO NOT MERGE] pkg/readiness: Add readiness checks and wire into proposal controller#1406

Closed
jhadvig wants to merge 1 commit into
openshift:mainfrom
jhadvig:readiness_pkg
Closed

[DO NOT MERGE] pkg/readiness: Add readiness checks and wire into proposal controller#1406
jhadvig wants to merge 1 commit into
openshift:mainfrom
jhadvig:readiness_pkg

Conversation

@jhadvig

@jhadvig jhadvig commented Jun 17, 2026

Copy link
Copy Markdown
Member

DUP OF #1395

Add pkg/readiness package with 9 cluster readiness checks that gather pre-upgrade health data: cluster conditions, operator health, API deprecations, node capacity, PDB drain blockers, etcd health, network config, CRD compatibility, and OLM operator lifecycle.

Wire readiness.RunAll() into the proposal controller, replacing the hardcoded readinessJSON placeholder with real per-target readiness data that gets embedded in each proposal's request body.

Plumb dynamic.Interface from pkg/start through cvo.New() to the proposal controller to support the readiness checks' cluster queries.

Add pkg/readiness package with 9 cluster readiness checks that gather
pre-upgrade health data: cluster conditions, operator health, API
deprecations, node capacity, PDB drain blockers, etcd health, network
config, CRD compatibility, and OLM operator lifecycle.

Wire readiness.RunAll() into the proposal controller, replacing the
hardcoded readinessJSON placeholder with real per-target readiness data
that gets embedded in each proposal's request body.

Plumb dynamic.Interface from pkg/start through cvo.New() to the proposal
controller to support the readiness checks' cluster queries.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jhadvig
Once this PR has been reviewed and has the lgtm label, please assign hongkailiu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhadvig

jhadvig commented Jun 17, 2026

Copy link
Copy Markdown
Member Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2026
@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@jhadvig: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-techpreview-serial-1of3 908b69b link true /test e2e-agnostic-ovn-techpreview-serial-1of3
ci/prow/e2e-agnostic-ovn 908b69b link true /test e2e-agnostic-ovn
ci/prow/verify-update 908b69b link true /test verify-update
ci/prow/e2e-aws-ovn-techpreview 908b69b link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-hypershift-conformance 908b69b link true /test e2e-hypershift-conformance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jhadvig jhadvig closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants