OCPBUGS-79662 - Modify ETCDCTL_RESTORE_FLAGS to include --skip-hash-check

[dhensel-rh]

There is a failure to restore learners. This fix will allow learners to be restored.

Summary by CodeRabbit

• Bug Fixes
  • Modified ETCD cluster snapshot restore to skip hash verification during the restoration process, streamlining the restore operation.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6228bd30-7b5f-427e-8f84-d9009bab3900

📥 Commits

Reviewing files that changed from the base of the PR and between 653c09f and f5e8590.

📒 Files selected for processing (1)

• bindata/etcd/cluster-restore-tnf.sh

---

Walkthrough

Added the --skip-hash-check flag to the ETCDCTL_RESTORE_FLAGS array in the etcd cluster restore script, which disables hash verification during snapshot restore operations.

Changes

Cohort / File(s)	Summary
etcd restore configuration bindata/etcd/cluster-restore-tnf.sh	Added --skip-hash-check flag to ETCDCTL_RESTORE_FLAGS array to skip hash verification during etcdctl snapshot restore.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 9 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (9 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title directly and accurately describes the main change: adding the --skip-hash-check flag to ETCDCTL_RESTORE_FLAGS.
Stable And Deterministic Test Names	✅ Passed	This custom check regarding stable and deterministic Ginkgo test names is not applicable to this pull request. The PR modifies only a bash shell script for ETCD cluster restoration operations containing no Ginkgo test definitions.
Test Structure And Quality	✅ Passed	The custom check for Ginkgo test code quality is inapplicable; the PR modifies only a bash shell script, not Go test files.
Microshift Test Compatibility	✅ Passed	The pull request only modifies a Bash shell script for etcd cluster restore operations and does not add any Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR does not add any Ginkgo e2e tests; it modifies a bash shell script for etcd snapshot restoration. SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The change adds --skip-hash-check flag to etcdctl restore command in a shell script, which does not introduce any Kubernetes scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The OTE Binary Stdout Contract check is not applicable to this pull request because it modifies a bash shell script used for etcd cluster restoration, not a compiled OTE binary.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR only modifies a shell script (cluster-restore-tnf.sh) to add the --skip-hash-check flag to ETCD restore operations. No Ginkgo e2e tests are added or modified.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dhensel-rh
Once this PR has been reviewed and has the lgtm label, please assign tjungblu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@dhensel-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-operator-disruptive	f5e8590	link	true	/test e2e-gcp-operator-disruptive
ci/prow/unit	f5e8590	link	true	/test unit
ci/prow/e2e-aws-ovn-single-node	f5e8590	link	true	/test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.