NO-JIRA: Merge https://github.com/kubernetes/cloud-provider-vsphere:release-1.35 (93af0f7) into main#113
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughBumped Go toolchain versions, upgraded many module and tooling pins, updated CI action pins, Makefile and Dockerfile Go image defaults, added Dependabot ignore rules for k8s modules, and a single unit test change to use Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Hi @cloud-team-rebase-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
e45c892 to
74a1231
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Around line 90-95: Update the OTLP trace exporter module versions to match the
core OpenTelemetry modules (v1.40.0): change
go.opentelemetry.io/otel/exporters/otlp/otlptrace and
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from v1.34.0 to
v1.40.0 in go.mod so all otel packages (go.opentelemetry.io/otel,
go.opentelemetry.io/otel/metric, go.opentelemetry.io/otel/sdk,
go.opentelemetry.io/otel/trace and the two otlptrace exporters) are aligned to
v1.40.0 and then run go mod tidy to refresh dependencies.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 85aadd34-f1bd-45d3-9e2d-8b75b4d2ac1f
⛔ Files ignored due to path filters (269)
go.sumis excluded by!**/*.sumhack/tools/go.sumis excluded by!**/*.sumhack/tools/vendor/github.com/google/pprof/profile/merge.gois excluded by!**/vendor/**hack/tools/vendor/github.com/google/pprof/profile/profile.gois excluded by!**/vendor/**hack/tools/vendor/github.com/google/pprof/profile/proto.gois excluded by!**/vendor/**hack/tools/vendor/github.com/google/pprof/profile/prune.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/ginkgo/command/command.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/run.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/ginkgo/run/run_command.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/internal/reporters/gojson.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/reporters/default_reporter.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/reporters/junit_report.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/reporters/teamcity_report.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/types/errors.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/types/semver_filter.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/types/types.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/types/version.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/mod/semver/semver.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sync/errgroup/errgroup.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/affinity_linux.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/fdset.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/ifreq_linux.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/mkall.shis excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/mkerrors.shis excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/syscall_linux.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/syscall_netbsd.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/syscall_solaris.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_386.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_amd64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_arm.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_arm64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_loong64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_mips.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_mips64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_mips64le.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_mipsle.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_ppc.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_ppc64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_ppc64le.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_riscv64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_s390x.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_sparc64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zsyscall_linux.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/ztypes_linux.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/ztypes_netbsd_arm.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/ast/inspector/cursor.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/packages/golist.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/packages/packages.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/packages/visit.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/types/objectpath/objectpath.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/types/typeutil/callee.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/types/typeutil/map.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/event/core/event.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/event/core/export.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/event/label/label.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/gcimporter/bimport.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/gcimporter/iexport.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/gcimporter/iimport.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/gcimporter/iimport_go122.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/stdlib/deps.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/stdlib/import.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/stdlib/manifest.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/stdlib/stdlib.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typeparams/normalize.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/classify_call.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/element.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/fx.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/isnamed.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/qualifier.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/types.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/varkind.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/varkind_go124.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/zerovalue.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/versions/features.gois excluded by!**/vendor/**hack/tools/vendor/modules.txtis excluded by!**/vendor/**test/e2e/go.sumis excluded by!**/*.sumtest/e2e/vendor/github.com/vmware/govmomi/fault/meta_types.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/internal/version/version.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/list/lister.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/object/datastore.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/object/folder.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/object/host_system.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/object/virtual_device_list.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vapi/internal/internal.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vapi/rest/client.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vapi/rest/errors.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vapi/rest/notifications.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/client.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/methods/methods.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/methods/unreleased.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/mo/extra.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/mo/registry.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/types/enum.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/types/guest.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/types/hardware_version.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/types/helpers.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/types/types.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/types/unreleased.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/net/http2/writesched_priority_rfc9218.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/net/websocket/hybi.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/cpu/cpu_x86.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/term/terminal.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/cases/tables10.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/cases/tables11.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/cases/tables12.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/cases/tables15.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/cases/tables17.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/cases/tables9.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/message/catalog/catalog.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/message/catalog/dict.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/message/catalog/go19.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/message/catalog/gopre19.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/secure/bidirule/bidirule.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/secure/bidirule/bidirule10.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/secure/bidirule/bidirule9.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables10.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables11.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables12.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables13.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables15.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables17.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables9.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/forminfo.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/tables10.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/tables11.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/tables12.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/tables15.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/tables17.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/tables9.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/go/ast/inspector/cursor.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/internal/stdlib/deps.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/internal/stdlib/manifest.gois excluded by!**/vendor/**test/e2e/vendor/modules.txtis excluded by!**/vendor/**vendor/go.opentelemetry.io/auto/sdk/internal/telemetry/id.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/auto/sdk/internal/telemetry/number.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/auto/sdk/internal/telemetry/span.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/auto/sdk/internal/telemetry/status.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/auto/sdk/internal/telemetry/traces.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/auto/sdk/internal/telemetry/value.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/auto/sdk/span.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/auto/sdk/tracer.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/.clomonitor.ymlis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/.codespellignoreis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/.lycheeignoreis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/CHANGELOG.mdis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/CODEOWNERSis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/CONTRIBUTING.mdis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/Makefileis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/README.mdis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/RELEASING.mdis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/SECURITY-INSIGHTS.ymlis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/VERSIONING.mdis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/encoder.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/filter.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/hash.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/internal/attribute.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/internal/xxhash/xxhash.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/iterator.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/key.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/kv.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/set.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/type_string.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/value.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/baggage/baggage.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/codes/codes.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/dependencies.Dockerfileis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/internal/global/instruments.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/internal/global/internal_logging.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/internal/global/meter.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/internal/global/trace.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/metric.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/metric/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/metric/asyncfloat64.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/metric/asyncint64.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/metric/config.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/metric/meter.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/metric/noop/noop.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/metric/syncfloat64.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/metric/syncint64.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/propagation/baggage.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/propagation/propagation.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/propagation/trace_context.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/internal/x/features.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/internal/x/x.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/builtin.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/container.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/env.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/host_id.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/host_id_bsd.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/host_id_linux.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/host_id_unsupported.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/host_id_windows.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/os.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/os_release_unix.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/os_unix.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/os_unsupported.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/process.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/resource.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/batch_span_processor.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/doc.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/id_generator.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/internal/env/env.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/batch_span_processor.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/doc.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/simple_span_processor.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/tracer.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/provider.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/sampling.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/simple_span_processor.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/snapshot.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/span.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/span_limits.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/tracer.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/version.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/version.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/internal/http.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.37.0/MIGRATION.mdis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.37.0/README.mdis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.37.0/attribute_group.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.37.0/doc.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.37.0/error_type.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.37.0/exception.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.37.0/schema.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.39.0/MIGRATION.mdis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.39.0/README.mdis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.39.0/attribute_group.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.39.0/doc.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.39.0/error_type.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.39.0/exception.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.39.0/otelconv/metric.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.39.0/schema.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/auto.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/config.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/hex.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/internal/telemetry/attr.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/internal/telemetry/id.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/internal/telemetry/value.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/noop.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/noop/noop.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/span.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/trace.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/tracestate.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/version.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/versions.yamlis excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/client_priority_go126.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/client_priority_go127.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/frame.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/http2.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/server.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/transport.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/writesched_priority_rfc7540.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/internal/httpsfv/httpsfv.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/cpu/cpu_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/cpu/cpu_other_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/cpu/cpu_windows_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ioctl_signed.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ioctl_unsigned.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/syscall_solaris.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/syscall_unix.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/windows/syscall_windows.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/windows/types_windows.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/windows/zsyscall_windows.gois excluded by!vendor/**,!**/vendor/**vendor/modules.txtis excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (4)
.github/workflows/weekly-security-scan.yamlgo.modhack/tools/go.modtest/e2e/go.mod
🚧 Files skipped from review as they are similar to previous changes (2)
- hack/tools/go.mod
- test/e2e/go.mod
74a1231 to
0f9b6ab
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
go.mod (1)
114-114:⚠️ Potential issue | 🟠 MajorUpgrade
google.golang.org/grpcto v1.79.3 or later to patch authorization bypass vulnerability.The project depends on
google.golang.org/grpc v1.72.2(an indirect dependency pulled by Kubernetes components), which is vulnerable to GHSA-p77j-4mvh-x3m3 / CVE-2026-33186—a critical authorization bypass affecting gRPC servers that use path-based authorization interceptors with fallback allow rules. The vulnerability stems from improper validation of HTTP/2:pathpseudo-headers, allowing non-canonical paths to bypass authorization checks.Patch version
1.79.3resolves this. Consider upgrading the direct dependency that pulls in grpc (likely through Kubernetes or etcd) to receive the patched version.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` at line 114, go.mod currently pins the indirect dependency google.golang.org/grpc at v1.72.2 which is vulnerable; update the grpc dependency to v1.79.3 or later by bumping google.golang.org/grpc in go.mod (or by upgrading the direct module that pulls it, e.g., the Kubernetes/etcd dependency) and then run the Go tooling (go get ./... or go get google.golang.org/grpc@v1.79.3 and go mod tidy) to ensure the indirect version is updated; verify with go list -m all that google.golang.org/grpc resolves to >= v1.79.3.
♻️ Duplicate comments (1)
go.mod (1)
91-92:⚠️ Potential issue | 🟠 MajorOTLP trace exporters remain misaligned with core OTel modules.
Lines 91–92 keep OTLP trace exporters at
v1.34.0while core OpenTelemetry modules (lines 90, 93–95) are now atv1.40.0. This version skew can lead to compatibility issues and missed bug fixes.Proposed version alignment
- go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.34.0 // indirect - go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.34.0 // indirect + go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.40.0 // indirect + go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.40.0 // indirectAfter applying the changes, run
go mod tidyto refresh dependencies.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` around lines 91 - 92, Update the OTLP trace exporter module versions to match the core OpenTelemetry modules by bumping go.opentelemetry.io/otel/exporters/otlp/otlptrace and go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from v1.34.0 to v1.40.0 in go.mod, then run `go mod tidy` to refresh and verify dependency alignment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@go.mod`:
- Line 114: go.mod currently pins the indirect dependency google.golang.org/grpc
at v1.72.2 which is vulnerable; update the grpc dependency to v1.79.3 or later
by bumping google.golang.org/grpc in go.mod (or by upgrading the direct module
that pulls it, e.g., the Kubernetes/etcd dependency) and then run the Go tooling
(go get ./... or go get google.golang.org/grpc@v1.79.3 and go mod tidy) to
ensure the indirect version is updated; verify with go list -m all that
google.golang.org/grpc resolves to >= v1.79.3.
---
Duplicate comments:
In `@go.mod`:
- Around line 91-92: Update the OTLP trace exporter module versions to match the
core OpenTelemetry modules by bumping
go.opentelemetry.io/otel/exporters/otlp/otlptrace and
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from v1.34.0 to
v1.40.0 in go.mod, then run `go mod tidy` to refresh and verify dependency
alignment.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 51ef335d-a546-421b-b1c1-346b7bc361c5
⛔ Files ignored due to path filters (294)
go.sumis excluded by!**/*.sumhack/tools/go.sumis excluded by!**/*.sumhack/tools/vendor/github.com/google/pprof/profile/merge.gois excluded by!**/vendor/**hack/tools/vendor/github.com/google/pprof/profile/profile.gois excluded by!**/vendor/**hack/tools/vendor/github.com/google/pprof/profile/proto.gois excluded by!**/vendor/**hack/tools/vendor/github.com/google/pprof/profile/prune.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/ginkgo/command/command.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/run.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/ginkgo/run/run_command.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/internal/reporters/gojson.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/reporters/default_reporter.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/reporters/junit_report.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/reporters/teamcity_report.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/types/errors.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/types/semver_filter.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/types/types.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/types/version.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/mod/semver/semver.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sync/errgroup/errgroup.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/affinity_linux.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/fdset.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/ifreq_linux.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/mkall.shis excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/mkerrors.shis excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/syscall_linux.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/syscall_netbsd.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/syscall_solaris.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_386.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_amd64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_arm.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_arm64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_loong64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_mips.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_mips64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_mips64le.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_mipsle.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_ppc.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_ppc64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_ppc64le.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_riscv64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_s390x.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_sparc64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zsyscall_linux.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/ztypes_linux.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/ztypes_netbsd_arm.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/ast/inspector/cursor.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/packages/golist.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/packages/packages.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/packages/visit.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/types/objectpath/objectpath.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/types/typeutil/callee.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/types/typeutil/map.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/event/core/event.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/event/core/export.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/event/label/label.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/gcimporter/bimport.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/gcimporter/iexport.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/gcimporter/iimport.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/gcimporter/iimport_go122.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/stdlib/deps.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/stdlib/import.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/stdlib/manifest.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/stdlib/stdlib.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typeparams/normalize.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/classify_call.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/element.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/fx.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/isnamed.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/qualifier.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/types.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/varkind.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/varkind_go124.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/zerovalue.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/versions/features.gois excluded by!**/vendor/**hack/tools/vendor/modules.txtis excluded by!**/vendor/**test/e2e/go.sumis excluded by!**/*.sumtest/e2e/vendor/github.com/vmware/govmomi/fault/meta_types.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/internal/version/version.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/list/lister.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/object/datastore.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/object/folder.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/object/host_system.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/object/virtual_device_list.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vapi/internal/internal.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vapi/rest/client.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vapi/rest/errors.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vapi/rest/notifications.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/client.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/methods/methods.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/methods/unreleased.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/mo/extra.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/mo/registry.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/types/enum.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/types/guest.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/types/hardware_version.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/types/helpers.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/types/types.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/types/unreleased.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/net/http2/writesched_priority_rfc9218.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/net/websocket/hybi.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/cpu/cpu_x86.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/term/terminal.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/cases/tables10.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/cases/tables11.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/cases/tables12.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/cases/tables15.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/cases/tables17.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/cases/tables9.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/message/catalog/catalog.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/message/catalog/dict.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/message/catalog/go19.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/message/catalog/gopre19.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/secure/bidirule/bidirule.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/secure/bidirule/bidirule10.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/secure/bidirule/bidirule9.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables10.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables11.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables12.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables13.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables15.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables17.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables9.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/forminfo.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/tables10.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/tables11.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/tables12.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/tables15.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/tables17.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/tables9.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/go/ast/inspector/cursor.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/internal/stdlib/deps.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/internal/stdlib/manifest.gois excluded by!**/vendor/**test/e2e/vendor/modules.txtis excluded by!**/vendor/**vendor/go.opentelemetry.io/auto/sdk/internal/telemetry/id.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/auto/sdk/internal/telemetry/number.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/auto/sdk/internal/telemetry/span.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/auto/sdk/internal/telemetry/status.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/auto/sdk/internal/telemetry/traces.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/auto/sdk/internal/telemetry/value.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/auto/sdk/span.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/auto/sdk/tracer.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/.clomonitor.ymlis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/.codespellignoreis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/.lycheeignoreis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/CHANGELOG.mdis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/CODEOWNERSis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/CONTRIBUTING.mdis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/Makefileis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/README.mdis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/RELEASING.mdis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/SECURITY-INSIGHTS.ymlis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/VERSIONING.mdis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/encoder.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/filter.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/hash.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/internal/attribute.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/internal/xxhash/xxhash.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/iterator.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/key.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/kv.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/set.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/type_string.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/value.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/baggage/baggage.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/codes/codes.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/dependencies.Dockerfileis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/internal/global/instruments.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/internal/global/internal_logging.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/internal/global/meter.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/internal/global/trace.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/metric.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/metric/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/metric/asyncfloat64.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/metric/asyncint64.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/metric/config.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/metric/meter.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/metric/noop/noop.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/metric/syncfloat64.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/metric/syncint64.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/propagation/baggage.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/propagation/propagation.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/propagation/trace_context.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/internal/x/features.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/internal/x/x.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/builtin.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/container.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/env.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/host_id.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/host_id_bsd.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/host_id_linux.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/host_id_unsupported.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/host_id_windows.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/os.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/os_release_unix.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/os_unix.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/os_unsupported.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/process.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/resource.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/batch_span_processor.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/doc.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/id_generator.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/internal/env/env.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/batch_span_processor.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/doc.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/simple_span_processor.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/tracer.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/provider.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/sampling.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/simple_span_processor.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/snapshot.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/span.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/span_limits.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/tracer.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/version.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/sdk/version.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/internal/http.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.37.0/MIGRATION.mdis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.37.0/README.mdis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.37.0/attribute_group.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.37.0/doc.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.37.0/error_type.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.37.0/exception.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.37.0/schema.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.39.0/MIGRATION.mdis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.39.0/README.mdis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.39.0/attribute_group.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.39.0/doc.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.39.0/error_type.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.39.0/exception.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.39.0/otelconv/metric.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.39.0/schema.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/auto.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/config.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/hex.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/internal/telemetry/attr.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/internal/telemetry/id.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/internal/telemetry/value.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/noop.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/noop/noop.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/span.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/trace.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/tracestate.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/version.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/versions.yamlis excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/client_priority_go126.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/client_priority_go127.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/frame.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/http2.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/server.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/transport.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/writesched.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/writesched_priority_rfc7540.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/writesched_random.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/internal/httpsfv/httpsfv.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sync/singleflight/singleflight.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/cpu/asm_darwin_arm64_gc.sis excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/cpu/cpu_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/cpu/cpu_darwin_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/cpu/cpu_darwin_arm64_other.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/cpu/cpu_gccgo_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/cpu/cpu_other_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/cpu/cpu_windows_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/cpu/syscall_darwin_arm64_gc.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/plan9/syscall_plan9.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ioctl_signed.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ioctl_unsigned.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/syscall_solaris.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/syscall_unix.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/windows/aliases.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/windows/registry/key.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/windows/syscall_windows.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/windows/types_windows.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/windows/zsyscall_windows.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/inspector/cursor.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/inspector/inspector.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/inspector/iter.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/packages.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/types/objectpath/objectpath.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/aliases/aliases.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/aliases/aliases_go122.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/event/core/event.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/event/keys/keys.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/event/label/label.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/iexport.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/iimport.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/ureader_yes.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/stdlib/deps.gois excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (6)
.github/workflows/weekly-security-scan.yamlMakefilecluster/images/controller-manager/Dockerfilego.modhack/tools/go.modtest/e2e/go.mod
✅ Files skipped from review due to trivial changes (5)
- .github/workflows/weekly-security-scan.yaml
- hack/tools/go.mod
- cluster/images/controller-manager/Dockerfile
- Makefile
- test/e2e/go.mod
0f9b6ab to
d44d927
Compare
…downgrade-release-to-k8s-1.35 Downgrade release-1.35 branch to k8s 1.35.1
…e-1.35 Bump dependencies to fix critical/high CVEs. - k8s.io/* v0.35.1 -> v0.35.2 (patch bump) - google.golang.org/grpc v1.72.2 -> v1.79.3 Fixes CVE-2026-33186: Authorization bypass via missing leading slash in :path (CVSS 9.1 Critical) - go.opentelemetry.io/otel/sdk v1.36.0 -> v1.40.0 Fixes CVE-2026-24051: Arbitrary code execution via PATH hijacking on macOS/Darwin (CVSS 7.0 High)
Dependabot automatically bumped k8s.io dependencies from v0.35.0-rc.0 to v0.36.0-alpha.0 on master before the release-1.35 branch was cut, causing the release branch to inherit wrong dependency versions. Add ignore rules for k8s.io/* to prevent this: - On master: block semver-minor and semver-major auto-bumps. Patch bumps (e.g. 0.35.1 -> 0.35.1) are still allowed. - On release branches (1.35, 1.34, 1.33): fully ignore k8s.io/* including patch updates. As a Kubernetes core component, cloud-provider-vsphere release branches follow the Kubernetes patch release schedule and k8s dependencies are updated manually.
…erry-pick-1720-to-release-1.35 [release-1.35] Prevent unwanted k8s.io version bumps by Dependabot
d44d927 to
1a8af19
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/dependabot.yml (1)
124-127: Consider documenting full-ignore intent consistently across all release blocks.The full
k8s.io/*ignore is clear in behavior, but only one block carries the rationale comment. Mirroring that note for each releasegomodsection would reduce future confusion.Also applies to: 172-172, 218-218, 263-263, 309-309, 354-354
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/dependabot.yml around lines 124 - 127, Add the same rationale comment explaining why k8s modules are fully ignored to every release gomod block that contains dependency-name: "k8s.io/*" (the occurrences mentioned in the review) so the intent is documented consistently; locate each gomod release block with dependency-name: "k8s.io/*" and insert the explanatory comment (matching the existing one: "Fully ignore k8s modules on release branches. All k8s dependency updates are done manually following the Kubernetes patch release schedule.") directly above that dependency entry.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/dependabot.yml:
- Around line 124-127: Add the same rationale comment explaining why k8s modules
are fully ignored to every release gomod block that contains dependency-name:
"k8s.io/*" (the occurrences mentioned in the review) so the intent is documented
consistently; locate each gomod release block with dependency-name: "k8s.io/*"
and insert the explanatory comment (matching the existing one: "Fully ignore k8s
modules on release branches. All k8s dependency updates are done manually
following the Kubernetes patch release schedule.") directly above that
dependency entry.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 947637d0-8e46-407c-9941-ce6268fcfff8
⛔ Files ignored due to path filters (292)
go.sumis excluded by!**/*.sumhack/tools/go.sumis excluded by!**/*.sumhack/tools/vendor/github.com/google/pprof/profile/merge.gois excluded by!**/vendor/**hack/tools/vendor/github.com/google/pprof/profile/profile.gois excluded by!**/vendor/**hack/tools/vendor/github.com/google/pprof/profile/proto.gois excluded by!**/vendor/**hack/tools/vendor/github.com/google/pprof/profile/prune.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/ginkgo/command/command.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/run.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/ginkgo/run/run_command.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/internal/reporters/gojson.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/reporters/default_reporter.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/reporters/junit_report.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/reporters/teamcity_report.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/types/errors.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/types/semver_filter.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/types/types.gois excluded by!**/vendor/**hack/tools/vendor/github.com/onsi/ginkgo/v2/types/version.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/mod/semver/semver.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sync/errgroup/errgroup.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/affinity_linux.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/fdset.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/ifreq_linux.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/mkall.shis excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/mkerrors.shis excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/syscall_linux.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/syscall_netbsd.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/syscall_solaris.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_386.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_amd64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_arm.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_arm64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_loong64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_mips.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_mips64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_mips64le.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_mipsle.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_ppc.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_ppc64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_ppc64le.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_riscv64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_s390x.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zerrors_linux_sparc64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zsyscall_linux.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/ztypes_linux.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/sys/unix/ztypes_netbsd_arm.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/ast/inspector/cursor.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/packages/golist.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/packages/packages.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/packages/visit.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/types/objectpath/objectpath.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/types/typeutil/callee.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/go/types/typeutil/map.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/event/core/event.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/event/core/export.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/event/label/label.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/gcimporter/bimport.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/gcimporter/iexport.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/gcimporter/iimport.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/gcimporter/iimport_go122.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/stdlib/deps.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/stdlib/import.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/stdlib/manifest.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/stdlib/stdlib.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typeparams/normalize.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/classify_call.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/element.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/fx.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/isnamed.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/qualifier.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/types.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/varkind.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/varkind_go124.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/typesinternal/zerovalue.gois excluded by!**/vendor/**hack/tools/vendor/golang.org/x/tools/internal/versions/features.gois excluded by!**/vendor/**hack/tools/vendor/modules.txtis excluded by!**/vendor/**test/e2e/go.sumis excluded by!**/*.sumtest/e2e/vendor/github.com/vmware/govmomi/fault/meta_types.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/internal/version/version.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/list/lister.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/object/datastore.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/object/folder.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/object/host_system.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/object/virtual_device_list.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vapi/internal/internal.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vapi/rest/client.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vapi/rest/errors.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vapi/rest/notifications.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/client.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/methods/methods.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/methods/unreleased.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/mo/extra.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/mo/registry.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/types/enum.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/types/guest.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/types/hardware_version.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/types/helpers.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/types/types.gois excluded by!**/vendor/**test/e2e/vendor/github.com/vmware/govmomi/vim25/types/unreleased.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/crypto/scrypt/scrypt.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/net/html/iter.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/net/html/node.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/net/html/nodetype_string.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/net/http2/client_priority_go126.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/net/http2/client_priority_go127.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/net/http2/frame.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/net/http2/http2.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/net/http2/server.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/net/http2/transport.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/net/http2/writesched_priority_rfc7540.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/net/http2/writesched_priority_rfc9218.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/net/internal/httpsfv/httpsfv.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/net/websocket/hybi.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sync/singleflight/singleflight.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/cpu/asm_darwin_arm64_gc.sis excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/cpu/cpu_arm64.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/cpu/cpu_darwin_arm64.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/cpu/cpu_darwin_arm64_other.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/cpu/cpu_gccgo_arm64.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/cpu/cpu_other_arm64.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/cpu/cpu_windows_arm64.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/cpu/cpu_x86.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/cpu/syscall_darwin_arm64_gc.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/plan9/syscall_plan9.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/unix/ioctl_signed.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/unix/ioctl_unsigned.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/unix/syscall_solaris.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/unix/syscall_unix.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/unix/ztypes_linux.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/windows/aliases.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/windows/registry/key.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/windows/syscall_windows.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/windows/types_windows.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/sys/windows/zsyscall_windows.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/term/terminal.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/cases/tables10.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/cases/tables11.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/cases/tables12.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/cases/tables15.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/cases/tables17.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/cases/tables9.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/message/catalog/catalog.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/message/catalog/dict.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/message/catalog/go19.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/message/catalog/gopre19.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/secure/bidirule/bidirule.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/secure/bidirule/bidirule10.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/secure/bidirule/bidirule9.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables10.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables11.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables12.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables13.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables15.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables17.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/bidi/tables9.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/forminfo.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/tables10.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/tables11.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/tables12.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/tables15.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/tables17.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/text/unicode/norm/tables9.0.0.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/go/ast/inspector/cursor.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/go/ast/inspector/inspector.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/go/ast/inspector/iter.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/go/packages/packages.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/go/types/objectpath/objectpath.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/internal/aliases/aliases.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/internal/aliases/aliases_go122.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/internal/event/core/event.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/internal/event/keys/keys.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/internal/event/label/label.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/internal/gcimporter/iexport.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/internal/gcimporter/iimport.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/internal/gcimporter/ureader_yes.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/internal/stdlib/deps.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/internal/stdlib/manifest.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/internal/typeparams/free.gois excluded by!**/vendor/**test/e2e/vendor/golang.org/x/tools/internal/typesinternal/types.gois excluded by!**/vendor/**test/e2e/vendor/modules.txtis excluded by!**/vendor/**vendor/cel.dev/expr/BUILD.bazelis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/MODULE.bazelis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/checked.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/eval.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/explain.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/syntax.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/value.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cenkalti/backoff/v4/context.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cenkalti/backoff/v4/exponential.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cenkalti/backoff/v4/retry.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cenkalti/backoff/v4/tries.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cenkalti/backoff/v5/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/cenkalti/backoff/v5/CHANGELOG.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/cenkalti/backoff/v5/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/cenkalti/backoff/v5/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/cenkalti/backoff/v5/backoff.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cenkalti/backoff/v5/error.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cenkalti/backoff/v5/exponential.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cenkalti/backoff/v5/retry.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cenkalti/backoff/v5/ticker.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cenkalti/backoff/v5/timer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/coreos/go-systemd/v22/daemon/sdnotify_other.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/coreos/go-systemd/v22/daemon/sdnotify_unix.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/coreos/go-systemd/v22/daemon/watchdog.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/coreos/go-systemd/v22/journal/journal.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/coreos/go-systemd/v22/journal/journal_unix.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/emicklei/go-restful/v3/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/emicklei/go-restful/v3/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/emicklei/go-restful/v3/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/emicklei/go-restful/v3/curly.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/emicklei/go-restful/v3/custom_verb.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/emicklei/go-restful/v3/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/evanphx/json-patch/v5/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/evanphx/json-patch/v5/errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/evanphx/json-patch/v5/internal/json/decode.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/evanphx/json-patch/v5/internal/json/encode.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/evanphx/json-patch/v5/internal/json/fold.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/evanphx/json-patch/v5/internal/json/fuzz.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/evanphx/json-patch/v5/internal/json/indent.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/evanphx/json-patch/v5/internal/json/scanner.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/evanphx/json-patch/v5/internal/json/stream.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/evanphx/json-patch/v5/internal/json/tables.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/evanphx/json-patch/v5/internal/json/tags.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/evanphx/json-patch/v5/merge.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/evanphx/json-patch/v5/patch.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gogo/protobuf/sortkeys/sortkeys.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/btree/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/google/btree/btree_generic.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/compare.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/export.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/internal/diff/debug_disable.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/internal/diff/debug_enable.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/internal/diff/diff.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/internal/flags/flags.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/internal/function/func.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/internal/value/name.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/internal/value/pointer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/internal/value/sort.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/path.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/report.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/report_compare.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/report_references.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/report_reflect.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/report_slices.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/report_text.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/report_value.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/client_metrics.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/client_options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/constants.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/reporter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/server_metrics.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/server_options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/COPYRIGHTis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/callmeta.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/client.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/reporter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/server.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/CHANGELOG.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/client.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/client_metrics.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/client_reporter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/makefileis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/metric_options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/server.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/server_metrics.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/server_reporter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-prometheus/util.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/openapiv2.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/openapiv2.protois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/openapiv2_protoopaque.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/BUILD.bazelis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/context.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/marshal_jsonpb.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/mux.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/expfmt/decode.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/expfmt/expfmt.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/expfmt/fuzz.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/expfmt/openmetrics_create.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/expfmt/text_create.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/expfmt/text_parse.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/Makefileis excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (8)
.github/dependabot.yml.github/workflows/weekly-security-scan.yamlMakefilecluster/images/controller-manager/Dockerfilego.modhack/tools/go.modpkg/cloudprovider/vsphereparavirtual/loadbalancer_test.gotest/e2e/go.mod
✅ Files skipped from review due to trivial changes (5)
- pkg/cloudprovider/vsphereparavirtual/loadbalancer_test.go
- .github/workflows/weekly-security-scan.yaml
- cluster/images/controller-manager/Dockerfile
- hack/tools/go.mod
- Makefile
🚧 Files skipped from review as they are similar to previous changes (2)
- test/e2e/go.mod
- go.mod
Update OWNERS according Openshift project needs. Remove upstream OWNERS_ALIASES file, we do not use it at the moment. # Conflicts: # OWNERS_ALIASES # Conflicts: # OWNERS_ALIASES # Conflicts: # OWNERS_ALIASES # Conflicts: # OWNERS_ALIASES
Added Openshift specific builds scripts, linter/tests/etc runners. Extended makefile with OCP specific targets. Upstream version of lint, and fmt pollutes go.mod and go.sum files, so, own versions of such scripts was introduced.
…ents OCP build system does expect *.assembly.stream.json and build system specific Dockerfile files to be copied into the build container. Remove respective entries from the .dockerignore to satisfy this requirement.
# Conflicts: # .github/workflows/release.yml # Conflicts: # .github/workflows/auto-release-helm-chart.yml # Conflicts: # .github/workflows/auto-release-helm-chart.yml # Conflicts: # .github/workflows/auto-release-helm-chart.yml # Conflicts: # .github/workflows/auto-release-helm-chart.yml # Conflicts: # .github/workflows/auto-release-helm-chart.yml
…ainer image to be consistent with ART for 4.22 Reconciling with https://github.com/openshift/ocp-build-data/tree/992b0dc3f0e12d86e7466dadf1eb51b2584a9a83/images/ose-vsphere-cloud-controller-manager.yml
1a8af19 to
681a90d
Compare
|
/ok-to-test |
|
This rebase fixes the incorrect kube 1.36.alpha dependencies from previous rebase. |
|
/label rebase/manual |
|
/retest-required |
|
regression job failure is flake. Fixed here: openshift/cluster-cloud-controller-manager-operator#444 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test ci/prow/regression-clusterinfra-vsphere-ipi-ccm |
|
/test regression-clusterinfra-vsphere-ipi-ccm |
|
/override ci/prow/okd-scos-images |
|
@damdo: Overrode contexts on behalf of damdo: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@cloud-team-rebase-bot[bot]: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by regression job prow/regression-clusterinfra-vsphere-ipi-ccm |
|
@RadekManak: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle NO-JIRA: Merge https://github.com/kubernetes/cloud-provider-vsphere:release-1.35 (93af0f7) into main |
|
@cloud-team-rebase-bot[bot]: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Summary by CodeRabbit