Skip to content

OCPBUGS-83973: Upgrade grpc for CVE-2026-33186#105

Open
nrb wants to merge 1 commit into
openshift:mainfrom
nrb:OCPBUGS-83973
Open

OCPBUGS-83973: Upgrade grpc for CVE-2026-33186#105
nrb wants to merge 1 commit into
openshift:mainfrom
nrb:OCPBUGS-83973

Conversation

@nrb
Copy link
Copy Markdown

@nrb nrb commented May 5, 2026

Summary by CodeRabbit

  • Chores
    • Dependency version updates to maintain stability and compatibility.

Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 5, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@nrb: This pull request references Jira Issue OCPBUGS-83973, which is invalid:

  • expected the vulnerability to target either version "5.0." or "openshift-5.0.", but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2c70441e-8154-4fe0-a7a6-1c79d9d85d81

📥 Commits

Reviewing files that changed from the base of the PR and between 5fbabb9 and 30b63e1.

⛔ Files ignored due to path filters (9)
  • go.sum is excluded by !**/*.sum
  • vendor/google.golang.org/grpc/internal/envconfig/envconfig.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/grpc/internal/transport/client_stream.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/grpc/internal/transport/http2_client.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/grpc/internal/transport/transport.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/grpc/server.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/grpc/stream.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/grpc/version.go is excluded by !**/vendor/**, !vendor/**
  • vendor/modules.txt is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (1)
  • go.mod

Walkthrough

A single indirect dependency version bump for google.golang.org/grpc from v1.79.1 to v1.79.3 in the Go module file.

Changes

Dependency Update

Layer / File(s) Summary
Module Dependency
go.mod
Indirect dependency google.golang.org/grpc is bumped from v1.79.1 to v1.79.3.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: upgrading gRPC to address a CVE vulnerability, with reference to the issue tracker number.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The custom check for stable/deterministic Ginkgo test names is not applicable to this PR. The PR modifies test files but all tests use standard Go testing (testing.T) framework, not Ginkgo.
Test Structure And Quality ✅ Passed This PR updates go.mod for a gRPC CVE fix. The codebase uses standard Go testing, not Ginkgo. The custom check for "Ginkgo test code" is not applicable to this repository.
Microshift Test Compatibility ✅ Passed PR only updates grpc dependency in go.mod. No new Ginkgo e2e tests added. Repository uses standard Go testing, not Ginkgo. Check not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only updates grpc dependency in go.mod. No new Ginkgo e2e tests added. Repository is a Kubernetes Cloud Provider using standard Go testing, not Ginkgo. Check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only updates grpc dependency. No deployment manifests or operator code modified. Check applies only to such changes.
Ote Binary Stdout Contract ✅ Passed Dependency upgrade only, no code changes. Not an OTE binary; check not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests added. PR only updates go.mod dependency versions for CVE-2026-33186. Custom check only applies when new Ginkgo tests are introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from racheljpg and theobarberbany May 5, 2026 16:41
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nrb
Copy link
Copy Markdown
Author

nrb commented May 5, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 5, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@nrb: This pull request references Jira Issue OCPBUGS-83973, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 5, 2026

@nrb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 30b63e1 link true /test e2e-aws-ovn
ci/prow/regression-clusterinfra-ibmcloud-ipi-ccm 30b63e1 link false /test regression-clusterinfra-ibmcloud-ipi-ccm
ci/prow/verify-commits 30b63e1 link false /test verify-commits

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants