Skip to content

[config] Remove forge config#88

Merged
kpouget merged 3 commits into
openshift-psap:mainfrom
kpouget:forge
May 13, 2026
Merged

[config] Remove forge config#88
kpouget merged 3 commits into
openshift-psap:mainfrom
kpouget:forge

Conversation

@kpouget
Copy link
Copy Markdown
Collaborator

@kpouget kpouget commented May 13, 2026

will be moved to openshift-psap/forge

Summary by CodeRabbit

  • Chores
    • Removed Forge build pipeline configurations, including Tekton workflows and task definitions.
    • Removed image stream and build run manifests.
    • Removed deployment orchestration helpers and sample job specifications.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sjmonson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ba5c17fe-647d-44f0-b938-62d51ed17745

📥 Commits

Reviewing files that changed from the base of the PR and between 259f694 and e372ec8.

📒 Files selected for processing (11)
  • config/forge/images/build_forge-main.yaml
  • config/forge/images/buildrun_forge-main.yaml
  • config/forge/images/is_forge.yaml
  • config/forge/samples/job-full.yaml
  • config/forge/samples/job-test-only.yaml
  • config/forge/workflows/pipeline-full.yaml
  • config/forge/workflows/pipeline-test-only.yaml
  • config/forge/workflows/tasks.yaml
  • hacks/copy-kubeconfig-secrets-to-ns.sh
  • tests/forge/deploy/orchestration/config.yaml
  • tests/forge/deploy/orchestration/deploy.py
💤 Files with no reviewable changes (11)
  • hacks/copy-kubeconfig-secrets-to-ns.sh
  • config/forge/samples/job-full.yaml
  • config/forge/workflows/tasks.yaml
  • config/forge/images/build_forge-main.yaml
  • config/forge/samples/job-test-only.yaml
  • config/forge/images/buildrun_forge-main.yaml
  • config/forge/workflows/pipeline-test-only.yaml
  • config/forge/workflows/pipeline-full.yaml
  • config/forge/images/is_forge.yaml
  • tests/forge/deploy/orchestration/deploy.py
  • tests/forge/deploy/orchestration/config.yaml

📝 Walkthrough

Walkthrough

This pull request systematically removes all FORGE workflow infrastructure from the repository, including container image build manifests, Tekton pipeline and task definitions, sample job configurations, and test deployment orchestration code for the FORGE integration.

Changes

FORGE Feature Removal

Layer / File(s) Summary
Container image build infrastructure
config/forge/images/build_forge-main.yaml, config/forge/images/buildrun_forge-main.yaml, config/forge/images/is_forge.yaml
Removes Shipwright Build and BuildRun manifests for the forge-main-build image build job and the OpenShift ImageStream resource for forge-core image management.
Tekton workflow definitions
config/forge/workflows/pipeline-full.yaml, config/forge/workflows/pipeline-test-only.yaml, config/forge/workflows/tasks.yaml
Removes forge-full and forge-test-only Tekton pipelines and the forge-step task implementation that executed Fournos jobs via kubeconfig and environment variable injection.
Sample job configurations
config/forge/samples/job-full.yaml, config/forge/samples/job-test-only.yaml
Removes FournosJob sample manifests demonstrating the forge execution engine project configuration and environment variable bindings.
Deployment orchestration and utilities
tests/forge/deploy/orchestration/config.yaml, tests/forge/deploy/orchestration/deploy.py, hacks/copy-kubeconfig-secrets-to-ns.sh
Removes FORGE config references from test deployment manifests, eliminates deploy_workflow_config() and rebuild_workflow_images() orchestration functions, and deletes the kubeconfig secret copy utility script.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • openshift-psap/fournos#9: Introduces the same FORGE Shipwright/Tekton/sample manifests that this PR removes entirely.
  • openshift-psap/fournos#26: Adds the forge-step Tekton task and copy-kubeconfig-secrets-to-ns.sh script that this PR deletes.
  • openshift-psap/fournos#79: Rewrites deploy.py orchestration to include workflow-config and image-rebuild steps that this PR removes.

Suggested labels

lgtm

Suggested reviewers

  • avasilevskii

Poem

🐰 Farewell to Forge, once bright and bold,
Your pipelines and tasks no longer told,
Buildah images fade from view,
Tekton workflows say adieu.
The code moves on, the feature takes flight,
Simplicity emerges in the light. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title '[config] Remove forge config' directly describes the main objective: removing forge configuration from the repository, which is confirmed by all file deletions in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kpouget kpouget marked this pull request as draft May 13, 2026 07:17
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2026
@kpouget kpouget marked this pull request as ready for review May 13, 2026 08:33
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2026
kpouget added 3 commits May 13, 2026 11:17
will be moved to openshift-psap/forge
was relevant only when we had to have the kubeconfig available in the workflow namespace
@kpouget
Copy link
Copy Markdown
Collaborator Author

kpouget commented May 13, 2026

/test ?

@kpouget
Copy link
Copy Markdown
Collaborator Author

kpouget commented May 13, 2026

/test deploy-fournos-wip

@psap-forge-bot
Copy link
Copy Markdown

🟢 Test of 'fournos_deploy --project-source' succeeded after 00 hours 01 minutes 46 seconds 🟢

• Link to the test results.

• No reports generated...

Test configuration:

/test deploy-fournos-wip

Execution logs

@kpouget
Copy link
Copy Markdown
Collaborator Author

kpouget commented May 13, 2026

merging this, FORGE workload is now deployed via https://github.com/openshift-psap/forge/tree/main/fournos/gitops

@kpouget kpouget merged commit 80f13c8 into openshift-psap:main May 13, 2026
5 of 6 checks passed
@kpouget kpouget deleted the forge branch May 13, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant