Skip to content

enable the RMO testing and remove the AVO#60

Open
bmeng wants to merge 1 commit into
openshift-online:mainfrom
bmeng:rmo-test
Open

enable the RMO testing and remove the AVO#60
bmeng wants to merge 1 commit into
openshift-online:mainfrom
bmeng:rmo-test

Conversation

@bmeng
Copy link
Copy Markdown
Contributor

@bmeng bmeng commented May 21, 2026

Description

Added new step in pre-check to consider the cluster ready once the vpcendpoint is available.

Re-enable the RMO testing as there should be no delay now.
Remove the AVO testing as it is part of the pre-steps

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • CI/CD or tooling change

Testing

  • Unit tests pass (make test)
  • Integration tests pass (if applicable)
  • Manual verification completed

Checklist

  • My code follows the project's coding conventions
  • I have updated documentation as needed
  • I have added tests that prove my fix/feature works
  • All new and existing tests pass

@openshift-ci openshift-ci Bot requested review from gdbranco and ravitri May 21, 2026 03:47
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 5b8489b8-6aea-4772-a808-757d57c127c1

📥 Commits

Reviewing files that changed from the base of the PR and between c9659ed and 8a6b208.

📒 Files selected for processing (1)
  • test/e2e/managed_operators_test.go

Summary by CodeRabbit

  • Tests
    • Updated test suite structure for better organization and alignment with testing framework standards.

Walkthrough

This PR corrects test case declarations in the managed operators e2e test suite. The RMO RouteMonitors test header is fixed from PIt(...) to It(...) to align with the Ginkgo API, and the AVO VpcEndpoints management-cluster test block is removed, allowing the test flow to proceed directly from RMO to the audit-webhook test.

Changes

Test Case Corrections

Layer / File(s) Summary
Test case declaration fixes
test/e2e/managed_operators_test.go
RMO RouteMonitors test declaration corrected from PIt(...) to It(...), and entire AVO VpcEndpoints management-cluster test block removed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and concisely summarizes the two main changes: enabling RMO testing and removing AVO, which matches the core modifications in the changeset.
Description check ✅ Passed The description is related to the changeset, explaining the rationale for re-enabling RMO testing and removing AVO testing, though it mentions pre-check changes not visible in the provided file summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2026
@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented May 21, 2026

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2026
@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented May 21, 2026

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant