Skip to content

Fix redfish_verify_ca boolean handling in certificate #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rbbratta wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix redfish_verify_ca boolean handling in certificate #1839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ocp_install_env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,8 @@ function generate_ocp_host_manifest() {
encoded_password=$(echo -n "$password" | base64)
if is_lower_version "$(openshift_version $OCP_DIR)" "4.22"; then
# Heads up, "verify_ca" in ironic driver config, and "disableCertificateVerification" in BMH have opposite meaning
disableCertificateVerification=$([ "$verify_ca" = "False" ] && echo "true" || echo "false")
# Handle both boolean false and string "False" - jq outputs boolean false as lowercase "false"
disableCertificateVerification=$([[ "${verify_ca,,}" = "false" ]] && echo "true" || echo "false")
else
disableCertificateVerification=false
fi
Expand Down
3 changes: 2 additions & 1 deletion utils.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,8 @@ EOF
if is_lower_version "$(openshift_version $OCP_DIR)" "4.22"; then
# Heads up, "verify ca" in ironic driver config, and "disableCertificateVerification" in BMH have opposite meaning
verify_ca=$(node_val ${idx} "driver_info.redfish_verify_ca")
disable_certificate_verification=$([ "$verify_ca" = "False" ] && echo "true" || echo "false")
# Handle both boolean false and string "False" - jq outputs boolean false as lowercase "false"
disable_certificate_verification=$([[ "${verify_ca,,}" = "false" ]] && echo "true" || echo "false")
cat << EOF
disableCertificateVerification: ${disable_certificate_verification}
EOF
Expand Down