AGENT-1193: Add mirror-path and registry-cert support for OVE ISO builds #1830
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
rwsu
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/cc @andfasano @bfournie @pawanpinjarkar |
openshift-ci
bot
requested review from
andfasano,
bfournie and
pawanpinjarkar
and removed request for
celebdor
rwsu
force-pushed
the
AGENT-1193-v3
branch
3 times, most recently
from
deee8cc to
10b8460
Compare
Add support for using pre-mirrored images (--mirror-path) and custom registry certificates (--registry-cert) when building OVE ISOs. This allows building ISOs in disconnected environments without requiring oc-mirror to run during the build process. Note: mirror-path and registry-cert options are only available when using the script build method (AGENT_ISO_NO_REGISTRY_BUILD_METHOD=script). The container build method does not support these options. Changes: - Refactor create_agent_iso_no_registry() for better readability - Extract helper functions into agent/iso_no_registry.sh - Add mirror-path and registry-cert support to script build method - Pass mirror-path to skip oc-mirror execution in appliance - Pass registry certificate for custom registries with self-signed certs Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com>
|
@rwsu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| if [[ "${MIRROR_IMAGES}" == "true" ]]; then | ||
| echo "Using mirrored release image: ${release_image_url}" | ||
| else | ||
| echo "Using upstream release image: ${release_image_url}" |
There was a problem hiding this comment.
guess it's a typo, both urls are the same
2 participants
Add support for using pre-mirrored images and custom registry certificates when building OVE ISOs, enabling disconnected deployments with custom registries.
Changes for mirror-path:
Changes for registry-cert:
Assisted-by: Claude Sonnet 4.5 noreply@anthropic.com