OCPBUGS-62684: telco-ran: remove crun extra-manifests and complete extra-manifests reorg by irinamihai · Pull Request #883 · openshift-kni/telco-reference

irinamihai · 2026-07-30T18:55:13Z

RAN only:

Finish cleaning up the extra-manifest restructuring in telco-ran.
crun is now the default, so its extra-manifest can be removed.
https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/release_notes/ocp-4-18-release-notes#ocp-release-notes-nodes-crun-default_release-notes
https://github.com/openshift/machine-config-operator/pull/4437/changes

…tra-manifests reorg

openshift-ci-robot · 2026-07-30T18:55:19Z

@irinamihai: This pull request references Jira Issue OCPBUGS-62684, which is invalid:

expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.22" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-07-30T18:55:31Z

📝 Walkthrough

Walkthrough

Changes

ClusterInstance install manifests

Layer / File(s)	Summary
ClusterInstance manifest layout `telco-ran/configuration/argocd/AdditionalManifests.md`, `telco-ran/configuration/source-crs/optional-extra-manifest/README.md`, `telco-ran/install/README.md`, `telco-ran/install/clusterinstance/custom-manifests/README.md`	Documentation moves reference and optional install manifests under `install/clusterinstance/` and describes `ClusterInstance.spec.extraManifestsRefs` usage.
MachineConfig templates `telco-ran/install/clusterinstance/extra-manifests/*.tmpl`	Adds templates for TPM2/NBDE disk encryption and role-scoped image registry partitions.
CRUN validation removal `telco-ran/configuration/compare.sh`, `telco-ran/configuration/kube-compare-reference/{hack/compare_ignore,metadata.yaml}`	Removes CRUN manifests from install-time content, required references, ignore rules, and comparison checks.

Estimated code review effort: 2 (Simple) | ~15 minutes

Suggested reviewers: kchennag

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided, so there is nothing to validate against the changeset.	Add a brief description summarizing the main changes and affected paths.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely describes the removal of crun extra manifests and completion of the extra-manifests reorganization.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@telco-ran/install/clusterinstance/extra-manifests/image-registry-partition-mc.yaml.tmpl`:
- Around line 1-10: Update the template around the .Data.Nodes iteration to emit
exactly one role-level MachineConfig for each $.Role. Aggregate the partition
information from all partitioned nodes before rendering, or explicitly reject
conflicting per-node inputs; do not render the same
98-var-imageregistry-partition-{{ $.Role }} manifest repeatedly without
separators.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: bcfa60b7-8305-49e8-a244-f5591f8d29a5

📥 Commits

Reviewing files that changed from the base of the PR and between f9edd30 and f3f4c66.

📒 Files selected for processing (14)

telco-ran/configuration/argocd/AdditionalManifests.md
telco-ran/configuration/compare.sh
telco-ran/configuration/kube-compare-reference/hack/compare_ignore
telco-ran/configuration/kube-compare-reference/machine-config/crun/enable-crun-master.yaml
telco-ran/configuration/kube-compare-reference/machine-config/crun/enable-crun-worker.yaml
telco-ran/configuration/kube-compare-reference/metadata.yaml
telco-ran/configuration/source-crs/optional-extra-manifest/README.md
telco-ran/install/README.md
telco-ran/install/clusterinstance/custom-manifests/README.md
telco-ran/install/clusterinstance/extra-manifests/disk-encryption.yaml.tmpl
telco-ran/install/clusterinstance/extra-manifests/image-registry-partition-mc.yaml.tmpl
telco-ran/install/custom-manifests/README.md
telco-ran/install/custom-manifests/enable-crun-master.yaml
telco-ran/install/custom-manifests/enable-crun-worker.yaml

💤 Files with no reviewable changes (8)

telco-ran/configuration/kube-compare-reference/machine-config/crun/enable-crun-worker.yaml
telco-ran/install/custom-manifests/enable-crun-worker.yaml
telco-ran/configuration/kube-compare-reference/machine-config/crun/enable-crun-master.yaml
telco-ran/install/custom-manifests/enable-crun-master.yaml
telco-ran/install/custom-manifests/README.md
telco-ran/configuration/kube-compare-reference/metadata.yaml
telco-ran/configuration/kube-compare-reference/hack/compare_ignore
telco-ran/configuration/compare.sh

coderabbitai

Caution

Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.