-
Notifications
You must be signed in to change notification settings - Fork 14
HYPERFLEET-618: add PostgreSQL advisory locks for migration coordination #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ldornele
wants to merge
7
commits into
openshift-hyperfleet:main
Choose a base branch
from
ldornele:HYPERFLEET-618
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,314
−10
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d0aa71f
HYPERFLEET-618: add PostgreSQL advisory locks for migration coordination
ldornele eda930a
HYPERFLEET-618: refactoring after code review feedback
ldornele 64c865a
HYPERFLEET-618: refactoring suggested by coderabbitai
ldornele 6b019f1
Merge branch 'main' into HYPERFLEET-618
ldornele 601e80a
Update test/integration/advisory_locks_test.go
ldornele a951454
HYPERFLEET-618 - test: add DatabaseConfig test coverage and improve a…
ldornele 2d44ef6
HYPERFLEET-618 - Fix linter issues: break long lines, use tagged swit…
ldornele File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Priority: Pattern
The new --db-advisory-lock-timeout flag (line 80) and DB_ADVISORY_LOCK_TIMEOUT
env var binding (line 107) have no unit test coverage. The env var logic
silently ignores invalid values (0, -1, "abc") which could surprise operators.
The repo already has thorough AddFlags/BindEnv tests for LoggingConfig in
logging_test.go. Consider adding equivalent tests for DatabaseConfig covering:
default value, flag override, env var override, flag-over-env precedence, and
invalid env var handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've added comprehensive test coverage for DatabaseConfig in pkg/config/db_test.go following the same patterns established in logging_test.go.
Tests added:
- Validates AdvisoryLockTimeoutSeconds = 300 (5 minutes)
- Validates Debug = false
- Verifies --db-advisory-lock-timeout flag registration
- Tests flag parsing with custom values (e.g., --db-advisory-lock-timeout=600)
- Tests DB_ADVISORY_LOCK_TIMEOUT and DB_DEBUG env var binding
- Validates env vars override defaults when no flag is set
- Verifies flags take priority over env vars
- Tests mixed scenarios (flag for timeout, env for debug)
- Tests exactly the cases you mentioned: 0, -1, "abc"
- Documents silent fallback behavior with t.Logf()
- Invalid values keep the default (300 seconds)
Coverage highlights: