Skip to content

Fix oc-mirror component mapping for Sippy dashboard#667

Open
aguidirh wants to merge 1 commit intoopenshift-eng:mainfrom
aguidirh:fix-oc-mirror-component-mapping
Open

Fix oc-mirror component mapping for Sippy dashboard#667
aguidirh wants to merge 1 commit intoopenshift-eng:mainfrom
aguidirh:fix-oc-mirror-component-mapping

Conversation

@aguidirh
Copy link
Copy Markdown

@aguidirh aguidirh commented Apr 1, 2026

Fix oc-mirror component mapping for Sippy dashboard

Problem

The oc-mirror component was not appearing in the Sippy dashboard because:

  1. Empty matchers - The component definition had an empty Matchers array, so it couldn't identify any tests
  2. Orphaned duplicate component - There was an unused duplicate component at pkg/components/oc/ocmirror/ from when the Jira component was named oc / oc-mirror (now renamed to oc-mirror)

As a result, all oc-mirror tests were being incorrectly mapped to the parent oc component instead of oc-mirror.

Solution

Added test matchers:

  • Added matchers to pkg/components/ocmirror/component.go to identify tests containing ocmirror or oc-mirror
  • Set Priority=5 to resolve ownership conflicts with the parent oc component (which also matches Workloads suite tests)

Cleaned up legacy code:

  • Removed orphaned pkg/components/oc/ocmirror/ directory that was never registered in the component registry

Updated mappings:

  • Ran make mapping to regenerate test mappings
  • Remapped 137 tests from oc component to oc-mirror component (Jira Component ID: 14970)

Test Examples

Tests now properly mapped to oc-mirror:

  • OCP-46520: Local backend support for oc-mirror
  • OCP-46523: Check the User Agent for oc-mirror
  • OCP-51093: oc-mirror init
  • OCP-72708: ocmirror v2 works well support delete function
  • OCP-75502: IBM Operator Index mirrored by oc-mirror
  • And 132 more...

Result

✅ The oc-mirror component will now appear in the Sippy dashboard with its 137 tests properly attributed
✅ Tests are correctly mapped to Jira component oc-mirror (ID: 14970)
✅ No test ownership conflicts

Checklist

  • Ran make mapping and committed the results
  • Verified no tests moved to Unknown component
  • Removed orphaned/unused component code
  • Set proper priority to resolve component conflicts

@openshift-ci openshift-ci bot requested a review from deads2k April 1, 2026 14:56
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 1, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aguidirh
Once this PR has been reviewed and has the lgtm label, please assign smg247 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from xueqzhan April 1, 2026 14:56
@MayXuQQ
Copy link
Copy Markdown

MayXuQQ commented Apr 1, 2026

/retest-required

@MayXuQQ
Copy link
Copy Markdown

MayXuQQ commented Apr 2, 2026

@xueqzhan could you help review? Thanks

@MayXuQQ
Copy link
Copy Markdown

MayXuQQ commented Apr 3, 2026

@deads2k Could you help review? Thanks

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2026
@aguidirh aguidirh force-pushed the fix-oc-mirror-component-mapping branch from d7cb0b5 to 351981d Compare April 10, 2026 05:48
The oc-mirror component was not appearing in Sippy dashboard due to:
1. Empty matchers - component couldn't identify any tests
2. Orphaned duplicate component at pkg/components/oc/ocmirror

Changes:
- Add matchers to pkg/components/ocmirror/component.go to identify
  tests containing 'ocmirror' or 'oc-mirror'
- Set Priority=5 to resolve conflicts with parent 'oc' component
- Remove orphaned pkg/components/oc/ocmirror/ directory (legacy from
  when Jira component was 'oc / oc-mirror')
- Remap 137 tests from 'oc' to 'oc-mirror' component

This enables oc-mirror tests to appear correctly in the Sippy dashboard
with proper Jira component mapping (JIRA ID: 14970).

Signed-off-by: Alex Guidi <aguidi@redhat.com>
@aguidirh aguidirh force-pushed the fix-oc-mirror-component-mapping branch from 351981d to c82d8f1 Compare April 10, 2026 08:52
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2026
@aguidirh
Copy link
Copy Markdown
Author

@deads2k could you please have a look?

@kasturinarra are you also a reviewer on this repo?

@kasturinarra
Copy link
Copy Markdown

@deads2k could you please have a look?

@kasturinarra are you also a reviewer on this repo?

@aguidirh no, i am not a reviewer actually on this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants