Skip to content

Replace deprecated datetime.utcnow() with timezone-aware datetime.now(timezone.utc) #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msarg44 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Replace deprecated datetime.utcnow() with timezone-aware datetime.now(timezone.utc) #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sentinel/ingest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import base64
import datetime
from datetime import datetime, timezone
import hashlib
import hmac
import json
Expand Down Expand Up @@ -29,7 +29,7 @@ def normalise(raw, scan_id):
return {
"ScanId": scan_id,
"FindingId": raw.get("id", ""),
"TimeGenerated": raw.get("detected_at", datetime.datetime.utcnow().isoformat() + "Z"),
"TimeGenerated": raw.get("detected_at", datetime.now(timezone.utc).isoformat()),
"ResourceId": raw.get("resource_id", ""),
"ResourceType": raw.get("resource_type", ""),
"ResourceName": raw.get("resource_name", ""),
Expand All @@ -51,7 +51,7 @@ def normalise(raw, scan_id):

def send(records):
body = json.dumps(records).encode("utf-8")
rfc_date = datetime.datetime.utcnow().strftime("%a, %d %b %Y %H:%M:%S GMT")
rfc_date = datetime.now(timezone.utc).strftime("%a, %d %b %Y %H:%M:%S GMT")
sig = build_signature(rfc_date, len(body))
url = f"https://{WORKSPACE_ID}.ods.opinsights.azure.com/api/logs?api-version=2016-04-01"
headers = {
Expand All @@ -77,7 +77,7 @@ def send(records):

def main():
path = sys.argv[1] if len(sys.argv) > 1 else "scanner/output/test_findings.json"
scan_id = sys.argv[2] if len(sys.argv) > 2 else datetime.datetime.utcnow().strftime("scan-%Y%m%d-%H%M")
scan_id = sys.argv[2] if len(sys.argv) > 2 else datetime.now(timezone.utc).strftime("scan-%Y%m%d-%H%M")
print(f"[INFO] Scan ID: {scan_id}")
with open(path) as f:
data = json.load(f)
Expand Down
Loading