fix(alerting): skip pluggable dataformat ITs on external clusters#2164
Merged
AWSHurneyt merged 3 commits intoMay 30, 2026
Conversation
…mains Reject creation, update, and execution of non-PPL monitors when the pluggable dataformat feature flag is enabled. Only PPL monitors are allowed on these domains. Delete and read operations are not blocked. Uses FeatureFlags.isEnabled(PLUGGABLE_DATAFORMAT_EXPERIMENTAL_FLAG) from OpenSearch core to gate the behavior. Also fixes missing settings registration in TransportIndexMonitorAction unit tests (MULTI_TENANT_TRIGGER_EVAL_ENABLED, PPL_MAX_QUERY_LENGTH, PPL_QUERY_RESULTS_MAX_DATAROWS, NOTIFICATION_SUBJECT_SOURCE_MAX_LENGTH, NOTIFICATION_MESSAGE_SOURCE_MAX_LENGTH) which were not reflected in the test setup. Signed-off-by: YashPradeep Gupte <yashprg@amazon.com>
Add assumeTrue guard to PluggableDataFormatMonitorBlockIT so tests skip gracefully when the feature flag is not enabled. Also gate the integTest.finalizedBy so integTestPluggableDataformat does not trigger when running against a remote cluster. Signed-off-by: YashPradeep Gupte <yashprg@amazon.com>
yashgupte21
requested review from
AWSHurneyt,
KashKondaka,
amsiglan,
bowenlan-amzn,
eirsep,
engechas,
getsaurabh02,
goyamegh,
lezzago,
manaswini1920,
nishtham-amazon,
rishabhmaurya,
riysaxen-amzn,
toepkerd and
vikhy-aws
as code owners
toepkerd
approved these changes
May 30, 2026
AWSHurneyt
approved these changes
May 30, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
assumeTrueguard toPluggableDataFormatMonitorBlockITso tests skip gracefully when theopensearch.experimental.feature.pluggable.dataformat.enabledfeature flag is not enabled on the cluster. Also gate theintegTest.finalizedBywithusingRemoteClustersointegTestPluggableDataformatdoes not trigger when running against a remote/external cluster.Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Fixes integration test failures during release CI, where
PluggableDataFormatMonitorBlockITwas triggered against an external cluster that did not have theopensearch.experimental.feature.pluggable.dataformat.enabledJVM system property set. Since this is a node startup property (not a runtime cluster setting), it cannot be toggled at test time, so tests must be skipped in environments without the flag.Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.