Skip to content

fix: correct inverted condition in DocLevelMonitorQueries causing query index churn #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thecodingshrimp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct inverted condition in DocLevelMonitorQueries causing query index churn #2154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions alerting/src/main/kotlin/org/opensearch/alerting/util/DocLevelMonitorQueries.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,13 +497,14 @@ class DocLevelMonitorQueries(private val client: Client, private val clusterServ
var targetQueryIndex = monitorMetadata.sourceToQueryIndexMapping[sourceIndex + monitor.id]
if (
targetQueryIndex == null || (
targetQueryIndex != monitor.dataSources.queryIndex &&
targetQueryIndex == monitor.dataSources.queryIndex &&
monitor.deleteQueryIndexInEveryRun == true
)
) {
// queryIndex is alias which will always have only 1 backing index which is writeIndex
// This is due to a fact that that _rollover API would maintain only single index under alias
// if you don't add is_write_index setting when creating index initially
// queryIndex is alias; its backing concrete index is the write index.
// The == guard handles the backwards-compat case where the alias name was mistakenly stored
// in metadata. Using != (the old code) caused this branch to fire on every run because
// the stored concrete index (e.g. "...-000001") always differs from the alias name.
targetQueryIndex = getWriteIndexNameForAlias(monitor.dataSources.queryIndex)
if (targetQueryIndex == null) {
val message = "Failed to get write index for queryIndex alias:${monitor.dataSources.queryIndex}"
Expand Down