analytics-eng: preserve a Sort under a Fetch in substrait conversion#21912
Open
mch2 wants to merge 1 commit into
Open
analytics-eng: preserve a Sort under a Fetch in substrait conversion#21912mch2 wants to merge 1 commit into
mch2 wants to merge 1 commit into
Conversation
A single Calcite LogicalSort that carries both a collation and a fetch/offset (a PPL `sort x | head N`, which Calcite merges into one node) lowers via isthmus to Fetch(Sort(input)) — two Substrait rels from one operator. DataFusionFragmentConvertor.replaceInput rewired the Fetch's input directly, dropping the Sort and producing Fetch(input). The limit then ran over the unordered concat-gather, so a multi-shard `sort | head N` returned the first N rows in arrival order instead of sorted order. Descend into the Sort when the Fetch's input is one, so the rewired shape is Fetch(Sort(newInput)): gather, sort globally, then limit. Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21912 +/- ##
============================================
- Coverage 73.51% 73.47% -0.05%
+ Complexity 75582 75526 -56
============================================
Files 6034 6034
Lines 342661 342661
Branches 49294 49294
============================================
- Hits 251918 251760 -158
- Misses 70712 70855 +143
- Partials 20031 20046 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A single Calcite LogicalSort that carries both a collation and a fetch/offset (a PPL
sort x | head N, which Calcite merges into one node) lowers via isthmus to Fetch(Sort(input)) — two Substrait rels from one operator. DataFusionFragmentConvertor.replaceInput rewired the Fetch's input directly, dropping the Sort and producing Fetch(input). The limit then ran over the unordered concat-gather, so a multi-shardsort | head Nreturned the first N rows in arrival order instead of sorted order.Descend into the Sort when the Fetch's input is one, so the rewired shape is Fetch(Sort(newInput)): gather, sort globally, then limit.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.