Skip Python sources in CombineSemanticallyEqualCatchBlocks#908
Merged
Conversation
The recipe's `CommentVisitor` is a `JavaIsoVisitor` that crashes in `TreeVisitorAdapter` when adapted to Python `Py.CompilationUnit` sources. Add a `PythonFileChecker` and use it as a precondition to exclude Python files while keeping Java, Kotlin, and Groovy support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CombineSemanticallyEqualCatchBlockscrashes on Python catch blocks (TreeVisitorAdapter + Python RPC) #907.CombineSemanticallyEqualCatchBlockscrashed inTreeVisitorAdapterwhen the recipe's innerCommentVisitor(aJavaIsoVisitor) was adapted to PythonPy.CompilationUnitsources. Added a newPythonFileCheckermirroring the existingKotlinFileChecker/GroovyFileCheckerpattern, and used it as a precondition (Preconditions.not(new PythonFileChecker<>())) so the recipe still runs on Java, Kotlin, and Groovy files but skips Python. Also addedrewrite-pythonas aprovideddependency to support the checker.Test plan
./gradlew test --tests CombineSemanticallyEqualCatchBlocksTest