Preserve raw cast on parameterized expression in RemoveRedundantTypeCast#905
Merged
Conversation
…Cast` A raw cast like `(B) b` where `b` is `B<T>` is an intentional unchecked conversion; removing it changes overload and type-inference behavior when the receiver is itself parameterized (e.g. `I<? extends T>`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve a raw cast like
(B) bwhenbisB<T>and the cast is a method-call argumentRemoving such a cast changes overload and type-inference behavior when the receiver is itself parameterized (e.g.
I<? extends T>), breaking compilationFixes RemoveRedundantTypeCast removes necessary Cast in Case when Generics are used #901
Test plan
doNotRemoveRawCastBridgingWildcardCapturereproducing the issueRemoveRedundantTypeCastTestsuite still passes./gradlew testpasses